Date: Mon, 27 Jul 2015 14:13:18 -0400
From: Tejun Heo <tj@kernel.org>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org, avanzini.arianna@gmail.com,
        kernel-team@fb.com, hannes@cmpxchg.org, lizefan@huawei.com,
        cgroups@vger.kernel.org
Subject: Re: [PATCHSET block/for-4.3] blkcg: implement interface for the
 unified hierarchy
Message-ID: <20150727181318.GA16393@mtj.duckdns.org>
References: <1437763434-28699-1-git-send-email-tj@kernel.org>
 <20150727161209.GB16064@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150727161209.GB16064@redhat.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1230
Lines: 33

Hello,

On Mon, Jul 27, 2015 at 12:12:09PM -0400, Vivek Goyal wrote:
> I browsed though the details of above knobs and it sounds great. It is
> clean and much less number of knobs and files. You got rid of all the
> debug CFQ knobs which is good. I was not happy with these either. Glad

Yeah, especially given that CFQ may be replaced by BFQ.

> to see that all the magic about leaf weight is gone. That was really
> mind bending. Knob for reset stats is gone and instead of mutiple files
> for configuration now we are using single file for R/W BPS/IOPS
> configuration.
> 
> I will do some basic testing and see if something pops up.
> 
> Userspace will need to understand these new files but that's the
> understanding anyway that unified hierarchy is different and needs
> to be handled differently.

For blkcg (and memory too), the usage model changes so drastically
that I don't think blkcg interface changes would matter much.
Everything is changed anyway.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/