Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754639AbbG0TFN (ORCPT ); Mon, 27 Jul 2015 15:05:13 -0400 Received: from mail-yk0-f172.google.com ([209.85.160.172]:34409 "EHLO mail-yk0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752790AbbG0TFJ (ORCPT ); Mon, 27 Jul 2015 15:05:09 -0400 Date: Mon, 27 Jul 2015 15:04:50 -0400 From: Jon Mason To: Kees Cook Cc: linux-kernel@vger.kernel.org, Dave Jiang , Allen Hubbe Subject: Re: [PATCH] ntb: avoid format string in dev_set_name Message-ID: <20150727190450.GA22852@kudzu.us> References: <20150724233559.GA15973@www.outflux.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150724233559.GA15973@www.outflux.net> User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1123 Lines: 39 On Fri, Jul 24, 2015 at 04:35:59PM -0700, Kees Cook wrote: > Avoid any chance of format string expansion when calling dev_set_name. Looks good to me. I'll pull it into my next release. Thanks, Jon > > Signed-off-by: Kees Cook > --- > drivers/ntb/ntb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ntb/ntb.c b/drivers/ntb/ntb.c > index 23435f2a5486..2e2530743831 100644 > --- a/drivers/ntb/ntb.c > +++ b/drivers/ntb/ntb.c > @@ -114,7 +114,7 @@ int ntb_register_device(struct ntb_dev *ntb) > ntb->dev.bus = &ntb_bus; > ntb->dev.parent = &ntb->pdev->dev; > ntb->dev.release = ntb_dev_release; > - dev_set_name(&ntb->dev, pci_name(ntb->pdev)); > + dev_set_name(&ntb->dev, "%s", pci_name(ntb->pdev)); > > ntb->ctx = NULL; > ntb->ctx_ops = NULL; > -- > 1.9.1 > > > -- > Kees Cook > Chrome OS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/