Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754845AbbG0VY5 (ORCPT ); Mon, 27 Jul 2015 17:24:57 -0400 Received: from mail-yk0-f174.google.com ([209.85.160.174]:35283 "EHLO mail-yk0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754578AbbG0VYz (ORCPT ); Mon, 27 Jul 2015 17:24:55 -0400 MIME-Version: 1.0 X-Originating-IP: [37.11.3.119] In-Reply-To: References: Date: Mon, 27 Jul 2015 23:24:54 +0200 Message-ID: Subject: Re: [PATCH v2] ARM: dts: Add SPI CS on exynos5250-snow From: Javier Martinez Canillas To: Michal Suchanek Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Kukjin Kim , Krzysztof Kozlowski , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-samsung-soc@vger.kernel.org" , Linux Kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1297 Lines: 44 Hello Michal, The patch looks good to me, just one small comment below. On Mon, Jul 27, 2015 at 10:11 PM, Michal Suchanek wrote: > Although there is only one choice of chipselect it is necessary to > specify it. The driver cannot claim the gpio otherwise. > > Signed-off-by: Michal Suchanek > > -- > v2 > - don't move unrelated line > --- > arch/arm/boot/dts/exynos5250-snow.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts > index b7f4122..62be08a 100644 > --- a/arch/arm/boot/dts/exynos5250-snow.dts > +++ b/arch/arm/boot/dts/exynos5250-snow.dts > @@ -688,6 +688,7 @@ > status = "okay"; > samsung,spi-src-clk = <0>; > num-cs = <1>; > + cs-gpios = <&gpa2 5 0>; NIT: this should be GPIO_ACTIVE_HIGH instead of 0 but maybe Kukjin or Krzysztof can fixup when applying it? > }; > > &usbdrd_dwc3 { > -- Acked-by: Javier Martinez Canillas Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/