Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754671AbbG0WY6 (ORCPT ); Mon, 27 Jul 2015 18:24:58 -0400 Received: from mga14.intel.com ([192.55.52.115]:27539 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753909AbbG0WY5 convert rfc822-to-8bit (ORCPT ); Mon, 27 Jul 2015 18:24:57 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,557,1432623600"; d="scan'208";a="614046407" From: "Liang, Kan" To: Jiri Olsa CC: "a.p.zijlstra@chello.nl" , "acme@kernel.org" , "luto@kernel.org" , "mingo@redhat.com" , "eranian@google.com" , "ak@linux.intel.com" , "mark.rutland@arm.com" , "Hunter, Adrian" , "jolsa@kernel.org" , "namhyung@kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH V2 4/6] perf,tools: save misc sample read value in struct perf_sample Thread-Topic: [PATCH V2 4/6] perf,tools: save misc sample read value in struct perf_sample Thread-Index: AQHQxlQ4xYBxtrJjbkKRV4K3iQgSdp3tbmOAgAJ5bLA= Date: Mon, 27 Jul 2015 22:24:49 +0000 Message-ID: <37D7C6CF3E00A74B8858931C1DB2F077018CD12B@SHSMSX103.ccr.corp.intel.com> References: <1437745712-16649-1-git-send-email-kan.liang@intel.com> <1437745712-16649-5-git-send-email-kan.liang@intel.com> <20150726163153.GF24646@krava.brq.redhat.com> In-Reply-To: <20150726163153.GF24646@krava.brq.redhat.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1881 Lines: 60 > -----Original Message----- > From: Jiri Olsa [mailto:jolsa@redhat.com] > Sent: Sunday, July 26, 2015 12:32 PM > To: Liang, Kan > Cc: a.p.zijlstra@chello.nl; acme@kernel.org; luto@kernel.org; > mingo@redhat.com; eranian@google.com; ak@linux.intel.com; > mark.rutland@arm.com; Hunter, Adrian; jolsa@kernel.org; > namhyung@kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH V2 4/6] perf,tools: save misc sample read value in > struct perf_sample > > On Fri, Jul 24, 2015 at 09:48:30AM -0400, kan.liang@intel.com wrote: > > SNIP > > > + u64 nr = 0; > > > > if (sid) { > > sample->id = v->id; > > @@ -1010,6 +1012,20 @@ static int deliver_sample_value(struct > perf_evlist *evlist, > > return 0; > > } > > > > + if (perf_evsel__is_group_leader(sid->evsel)) { > > + evsel = sid->evsel; > > + SET_FREQ_PERF_VALUE(evsel, sample->freq_perf_data, > > + sample->read.group.values[nr].value); > > + evlist__for_each_continue(evlist, evsel) { > > + if ((evsel->leader != sid->evsel) || > > + (++nr >= sample->read.group.nr)) > > + break; > > + > > + SET_FREQ_PERF_VALUE(evsel, sample- > >freq_perf_data, > > + sample- > >read.group.values[nr].value); > > I think this should be in upper layer.. OK, I'll move it to deliver_sample_group. > why not do this also within > iter_prepare_normal_entry as for the rest of the calculations I suggested > in my other email Because we cannot get evlist in iter_add/prepare function. We cannot go through all group members' value. It's too complex (need to change many interfaces) to pass the evlist to iter_add/prepare function Thanks, Kan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/