Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754881AbbG1Bo2 (ORCPT ); Mon, 27 Jul 2015 21:44:28 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:34600 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754512AbbG1Bo0 (ORCPT ); Mon, 27 Jul 2015 21:44:26 -0400 Subject: Re: [PATCH 1/1] serial: 8250_pci: add RS485 for F81504/508/512 To: =?UTF-8?Q?Jakub_Kici=c5=84ski?= , gregkh@linuxfoundation.org References: <1437717339-28881-1-git-send-email-hpeter+linux_kernel@gmail.com> <20150725113545.6bce8038@north> Cc: jslaby@suse.com, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, tom_tsai@fintek.com.tw, peter_hong@fintek.com.tw, Peter Hung From: Peter Hung Message-ID: <55B6DE75.8090309@gmail.com> Date: Tue, 28 Jul 2015 09:44:21 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20150725113545.6bce8038@north> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 761 Lines: 20 Hi Jakub Kiciński, Jakub Kiciński 於 2015/7/25 下午 05:35 寫道: > Please make sure you correct the rs485 configuration with what you can > actually support. Look at 8250_lpc18xx.c as an example. In your case > when the function returns it should have SER_RS485_ENABLED and one of > SER_RS485_RTS_ON_SEND | SER_RS485_RTS_AFTER_SEND set and nothing else > (or be completely zeroed if SER_RS485_ENABLED was not set). > Thanks for your advice, I'll fix it and re-send patch -- With Best Regards, Peter Hung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/