Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755022AbbG1Cgx (ORCPT ); Mon, 27 Jul 2015 22:36:53 -0400 Received: from tundra.namei.org ([65.99.196.166]:33120 "EHLO namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754525AbbG1Cgw (ORCPT ); Mon, 27 Jul 2015 22:36:52 -0400 Date: Tue, 28 Jul 2015 12:36:46 +1000 (AEST) From: James Morris To: Kees Cook cc: linux-security-module , James Morris , Casey Schaufler , LKML Subject: Re: [PATCH] LSM: LoadPin for module and firmware loading restrictions In-Reply-To: Message-ID: References: <20150724005330.GA15227@www.outflux.net> User-Agent: Alpine 2.20 (LRH 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 945 Lines: 30 On Mon, 27 Jul 2015, Kees Cook wrote: > On Sun, Jul 26, 2015 at 9:26 PM, James Morris wrote: > > On Thu, 23 Jul 2015, Kees Cook wrote: > > > >> + > >> +/* > >> + * Return an allocated string that has been escaped of special characters > >> + * and double quotes, making it safe to log in quotes. > >> + */ > >> +static char *kstrdup_quotable(char *src) > >> +{ > > > > Do you think these should go into a library? > > Possibly. There are some other areas of code that almost do the same > thing, but not exactly. Perhaps I'll first change Yama around to use > it, then send these again. Ok. Is this the same code being used in ChromeOS? -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/