Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752194AbbG1EZo (ORCPT ); Tue, 28 Jul 2015 00:25:44 -0400 Received: from mga02.intel.com ([134.134.136.20]:56185 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751176AbbG1EZm convert rfc822-to-8bit (ORCPT ); Tue, 28 Jul 2015 00:25:42 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,560,1432623600"; d="scan'208";a="531414628" From: "Du, Changbin" To: "'Andrzej Pietrasiewicz'" , Felipe Balbi CC: Greg Kroah-Hartman , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] usb/gadget: make composite gadget meet usb compliance for vbus draw Thread-Topic: [PATCH] usb/gadget: make composite gadget meet usb compliance for vbus draw Thread-Index: AdDFQ/v32ELIUcFWTwaMp7sIW5cuU///mb2A//6andCAAoUkAP//b5qA//jalcA= Date: Tue, 28 Jul 2015 04:25:37 +0000 Message-ID: <0C18FE92A7765D4EB9EE5D38D86A563A01D4E8A0@SHSMSX103.ccr.corp.intel.com> References: <0C18FE92A7765D4EB9EE5D38D86A563A01D14FD5@SHSMSX103.ccr.corp.intel.com> <55B0FA29.5080402@samsung.com> <0C18FE92A7765D4EB9EE5D38D86A563A01D49C90@SHSMSX103.ccr.corp.intel.com> <55B1EB8C.2080303@samsung.com> <0C18FE92A7765D4EB9EE5D38D86A563A01D4BDCD@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <0C18FE92A7765D4EB9EE5D38D86A563A01D4BDCD@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1670 Lines: 41 > > From: Andrzej Pietrasiewicz [mailto:andrzej.p@samsung.com] Hi, > > > > What I mean is that in my opinion it should be done in a separate > > patch, because the newly introduced USB_VBUS_DRAW_SUSPEND is not > used > > anywhere else in your patch. The meaning of this change is "use a > > symbolic name rather than an explicit number" and it is unrelated to > > making composite gadget meet usb compliance for vbus draw. In other > > words, if you don't do this change at all the compliance is still > > maintained, because the value of USB_VBUS_DRAW_SUSPEND is 2 anyway, > so > > what the compiler eventually sees is the same whether the change is > > made or not. > > > > My idea: > > > > [PATCHv2 0/2] usb gadget vbus draw compilance > > [PATCHv2 1/2] usb: gadget: composite: avoid using a magic number > > >> substituting an explicit "2" with USB_VBUS_DRAW_SUSPEND goes > > here << > > [PATCHv2 2/2] usb: gadget: composite: meet usb compliance for vbus > draw > > >> the rest of your changes go here << > > > > > Hi, Andrzej. When I try to split into two patches, I realized that it is not applicable. Because the original code doesn't distinguish different usb types, but new symbols does. So I cannot make a patch just avoid using a magic number without modify the control logic. Hence, I'd prefer doing them in a signal patch. I will send new modified patch. Thanks! Changbin. > > > > Andrzej -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/