Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753487AbbG1EaZ (ORCPT ); Tue, 28 Jul 2015 00:30:25 -0400 Received: from kirsty.vergenet.net ([202.4.237.240]:48724 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751088AbbG1EaY (ORCPT ); Tue, 28 Jul 2015 00:30:24 -0400 Date: Tue, 28 Jul 2015 13:30:19 +0900 From: Simon Horman To: Vivek Goyal Cc: Minfei Huang , Minfei Huang , kexec@lists.infradead.org, ebiederm@xmission.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] kexec: Remove the unnecessary conditional judgement to simplify the code logic Message-ID: <20150728043019.GC25714@verge.net.au> References: <1433571252-11874-1-git-send-email-mhuang@redhat.com> <20150727134453.GA16064@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150727134453.GA16064@redhat.com> Organisation: Horms Solutions Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 916 Lines: 21 On Mon, Jul 27, 2015 at 09:44:53AM -0400, Vivek Goyal wrote: > On Sat, Jun 06, 2015 at 02:14:12PM +0800, Minfei Huang wrote: > > From: Minfei Huang > > > > Transforming PFN(Page Frame Number) to struct page is never failure, so > > we can simplify the code logic to do the image->control_page assignment > > directly in the loop, and remove the unnecessary conditional judgement. > > > > Signed-off-by: Minfei Huang > > Looks good to me. > > Acked-by: Vivek Goyal FWIW, this probably needs to be reposted to Andrew Morton with appropriate Acks and CCs in order to proceed into his tree and then Linus's. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/