Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755045AbbG1Em3 (ORCPT ); Tue, 28 Jul 2015 00:42:29 -0400 Received: from mail-pd0-f170.google.com ([209.85.192.170]:36410 "EHLO mail-pd0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754510AbbG1EmO (ORCPT ); Tue, 28 Jul 2015 00:42:14 -0400 Date: Tue, 28 Jul 2015 12:42:08 +0800 From: Minfei Huang To: Simon Horman Cc: Vivek Goyal , Minfei Huang , kexec@lists.infradead.org, ebiederm@xmission.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] kexec: Remove the unnecessary conditional judgement to simplify the code logic Message-ID: <20150728044208.GA32290@t440s.lenovo> References: <1433571252-11874-1-git-send-email-mhuang@redhat.com> <20150727134453.GA16064@redhat.com> <20150728043019.GC25714@verge.net.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150728043019.GC25714@verge.net.au> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1052 Lines: 29 On 07/28/15 at 01:30pm, Simon Horman wrote: > On Mon, Jul 27, 2015 at 09:44:53AM -0400, Vivek Goyal wrote: > > On Sat, Jun 06, 2015 at 02:14:12PM +0800, Minfei Huang wrote: > > > From: Minfei Huang > > > > > > Transforming PFN(Page Frame Number) to struct page is never failure, so > > > we can simplify the code logic to do the image->control_page assignment > > > directly in the loop, and remove the unnecessary conditional judgement. > > > > > > Signed-off-by: Minfei Huang > > > > Looks good to me. > > > > Acked-by: Vivek Goyal > > FWIW, this probably needs to be reposted to Andrew Morton with appropriate > Acks and CCs in order to proceed into his tree and then Linus's. Thanks. I will repost it to Andrew Morton. Thanks Minfei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/