Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753586AbbG1Gba (ORCPT ); Tue, 28 Jul 2015 02:31:30 -0400 Received: from mail-pd0-f172.google.com ([209.85.192.172]:33043 "EHLO mail-pd0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750883AbbG1Gb3 convert rfc822-to-8bit (ORCPT ); Tue, 28 Jul 2015 02:31:29 -0400 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\)) Subject: Re: [RFC V2] arm64:use set_fixmap_offset to make it more clear From: yalin wang In-Reply-To: <9A8FA704-5D35-404B-BEBE-C92AF25505C3@gmail.com> Date: Tue, 28 Jul 2015 14:31:20 +0800 Cc: Will Deacon , zlim.lnx@gmail.com, punit.agrawal@arm.com, marc.zyngier@arm.com, lauraa@codeaurora.org, wcohen@redhat.com, linux-arm-kernel@lists.infradead.org, open list Content-Transfer-Encoding: 8BIT Message-Id: <21A5B6D3-B813-4DC3-B392-009991B9CA00@gmail.com> References: <9A8FA704-5D35-404B-BEBE-C92AF25505C3@gmail.com> To: Catalin Marinas X-Mailer: Apple Mail (2.2098) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1264 Lines: 40 > On Jul 24, 2015, at 19:52, yalin wang wrote: > > A little change to patch_map() function, > use set_fixmap_offset() to make code more clear. > > Signed-off-by: yalin wang > --- > arch/arm64/kernel/insn.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/kernel/insn.c b/arch/arm64/kernel/insn.c > index dd9671c..f341866 100644 > --- a/arch/arm64/kernel/insn.c > +++ b/arch/arm64/kernel/insn.c > @@ -101,9 +101,8 @@ static void __kprobes *patch_map(void *addr, int fixmap) > return addr; > > BUG_ON(!page); > - set_fixmap(fixmap, page_to_phys(page)); > - > - return (void *) (__fix_to_virt(fixmap) + (uintaddr & ~PAGE_MASK)); > + return (void *)set_fixmap_offset(fixmap, page_to_phys(page) + > + (uintaddr & ~PAGE_MASK)); > } > > static void __kprobes patch_unmap(int fixmap) > -- > 1.9.1 > Marinas, this V2 patch can build without warning even CONFIG_DEBUG_SET_MODULE_RONX enabled, could you review it. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/