Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753901AbbG1HVE (ORCPT ); Tue, 28 Jul 2015 03:21:04 -0400 Received: from 8bytes.org ([81.169.241.247]:33097 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751775AbbG1HVC (ORCPT ); Tue, 28 Jul 2015 03:21:02 -0400 Date: Tue, 28 Jul 2015 09:20:59 +0200 From: Joerg Roedel To: Peter Hurley Cc: Greg Kroah-Hartman , Jiri Slaby , Sebastian Andrzej Siewior , Tony Lindgren , Alan Cox , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Joerg Roedel , Michael Welling , Joe Schultz Subject: Re: [PATCH] serial: 8250: Do XR17V35X specific wakeup in serial8250_do_startup Message-ID: <20150728072059.GQ10969@8bytes.org> References: <1437035353-13708-1-git-send-email-joro@8bytes.org> <55A90467.9000804@hurleysoftware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55A90467.9000804@hurleysoftware.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1153 Lines: 35 Hi Peter, On Fri, Jul 17, 2015 at 09:34:31AM -0400, Peter Hurley wrote: > On 07/16/2015 04:29 AM, Joerg Roedel wrote: > > From: Joerg Roedel > > > > The XR17V35X UART needs the ECB bit set in its XR_EFR > > register to enable access to IER [7:5], ISR [5:4], FCR[5:4], > > MCR[7:5], and MSR [7:0]. > > > > Also reset the IER register to mask interrupts after access > > to all bits of this register has been enabled. > > > > This makes my 8-port XR17V35X working with the in-kernel > > serial driver. > > Reviewed-by: Peter Hurley Thanks for your review. > Also, would you please find out what bits are set in the IER > that this fixes and let me know? I don't have this hardware. Unfortunatly I put the card back into a production machine and can't easily check this anymore. But I'll let you know when I update the kernel on the box next time. Joerg -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/