Date: Tue, 28 Jul 2015 10:25:26 +0200
From: Jean-Francois Moine <moinejf@free.fr>
To: Nicholas Mc Guire <hofrat@osadl.org>
Cc: Russell King <rmk+kernel@arm.linux.org.uk>, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org
Subject: Re: [PATCH RFC] drm/i2c: tda998x: dead-code or unhandled error
 condition ?
Message-ID: <20150728102527.528f7d51@armhf>
In-Reply-To: <1433941128-19798-1-git-send-email-hofrat@osadl.org>
References: <1433941128-19798-1-git-send-email-hofrat@osadl.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1098
Lines: 26

On Wed, 10 Jun 2015 14:58:48 +0200
Nicholas Mc Guire <hofrat@osadl.org> wrote:

> event API conformance testing with coccinelle spatches are being
> used to locate API usage inconsistencies this triggert with:
> ./drivers/gpu/drm/i2c/tda998x_drv.c:1062
>         incorrect check for negative return
> 
> The return of wait_event_timeout is always >= 0, thus the negative 
> check was effectively being ignoring - as the timeout will be checked
> a few lines below the error condition being checked here seems to be
> wrong or this is simply dead code which would be my guess as the
> timeout condition check covers the wait-queue related failure condition.
> 
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>

Acked-by: Jean-Francois Moine <moinejf@free.fr>

-- 
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/