Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932164AbbG1I3l (ORCPT ); Tue, 28 Jul 2015 04:29:41 -0400 Received: from softlayer.compulab.co.il ([50.23.254.55]:56529 "EHLO compulab.co.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751447AbbG1I3j (ORCPT ); Tue, 28 Jul 2015 04:29:39 -0400 Subject: Re: [PATCH 1/2] ARM: dts: Add support for phyCORE-AM335x SoM To: Matt Porter , Teresa Remmet References: <1437035449-26956-1-git-send-email-t.remmet@phytec.de> <20150727143444.GD15004@beef> Cc: linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mark Rutland , Pawel Moll , Ian Campbell , Tony Lindgren , Rob Herring , =?UTF-8?Q?Beno=c3=aet_Cousson?= , Kumar Gala From: Igor Grinberg X-Enigmail-Draft-Status: N1110 Organization: CompuLab Ltd. Message-ID: <55B73D6D.2040801@compulab.co.il> Date: Tue, 28 Jul 2015 11:29:33 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20150727143444.GD15004@beef> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - softlayer.compulab.co.il X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - compulab.co.il X-Get-Message-Sender-Via: softlayer.compulab.co.il: acl_c_relayhosts_text_entry: grinberg@compulab.co.il|compulab.co.il Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2044 Lines: 63 Hi Matt, On 07/27/15 17:34, Matt Porter wrote: > On Thu, Jul 16, 2015 at 10:30:48AM +0200, Teresa Remmet wrote: >> phyCORE-AM335x is a SoM (System on Module) containing >> a AM335x SOC. The module can be connected to different >> carrier boards. >> >> Some hardware parts are configurable on the phyCORE-AM335x. >> So they are disabled on default in this som dtsi file. >> They will be enabled in the board dts files, when populated. >> >> * RAM up to 1GiB >> * PMIC >> * NAND flash up to 1GiB >> * Eth PHY on SOM: 1x RMII >> * SPI NOR flash 8MiB (optional) >> * i2c RTC (optional) >> * i2c EEPROM 4kiB (optional) >> >> Signed-off-by: Teresa Remmet >> --- >> arch/arm/boot/dts/am335x-phycore-som.dtsi | 368 ++++++++++++++++++++++++++++++ >> 1 file changed, 368 insertions(+) >> create mode 100644 arch/arm/boot/dts/am335x-phycore-som.dtsi >> >> diff --git a/arch/arm/boot/dts/am335x-phycore-som.dtsi b/arch/arm/boot/dts/am335x-phycore-som.dtsi >> new file mode 100644 >> index 0000000..4d28fc3 >> --- /dev/null >> +++ b/arch/arm/boot/dts/am335x-phycore-som.dtsi [...] >> +#include "am33xx.dtsi" >> + >> +/ { >> + model = "Phytec AM335x phyCORE"; >> + compatible = "phytec,am335x-phycore-som", "ti,am33xx"; > > One minor thing here...wildcards in compatible strings aren't permitted. > However, family compatibles like "ti,am33xx" that came in before this > was enforced are grandfathered. Ideally, the newly introced board/som > specific strings should not propagate that wildcard. i.e. something > like "phytec,am3352-phycore-som" or whatever is the base family part > on these SOMs. > I'm not sure this is wild card. I tend to think that it is the real name of the som [1], no? http://phytec.com/products/system-on-modules/phycore/am335x/ [...] -- Regards, Igor. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/