Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755493AbbG1IsM (ORCPT ); Tue, 28 Jul 2015 04:48:12 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:60505 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755457AbbG1IsG (ORCPT ); Tue, 28 Jul 2015 04:48:06 -0400 X-IronPort-AV: E=Sophos;i="5.15,562,1432591200"; d="scan'208";a="171858762" Date: Tue, 28 Jul 2015 10:47:39 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Shraddha Barke cc: Karsten Keil , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Drivers: isdn: Drop unnecessary continue In-Reply-To: <1438072868-5408-1-git-send-email-shraddha.6596@gmail.com> Message-ID: References: <1438072868-5408-1-git-send-email-shraddha.6596@gmail.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1423 Lines: 53 The patch should have v2 in the subject line, and should have a description of the change since the previous version under the --- On Tue, 28 Jul 2015, Shraddha Barke wrote: > The semantic patch used to make this change is : > > @@ > @@ > for (...;...;...) { > ... > if (...) { > ... > - continue; > } > } > > Signed-off-by: Shraddha Barke > --- > drivers/isdn/hardware/mISDN/hfcsusb.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/isdn/hardware/mISDN/hfcsusb.c b/drivers/isdn/hardware/mISDN/hfcsusb.c > index 114f3bc..91beb83 100644 > --- a/drivers/isdn/hardware/mISDN/hfcsusb.c > +++ b/drivers/isdn/hardware/mISDN/hfcsusb.c > @@ -1921,10 +1921,9 @@ hfcsusb_probe(struct usb_interface *intf, const struct usb_device_id *id) > if ((le16_to_cpu(dev->descriptor.idVendor) > == hfcsusb_idtab[i].idVendor) && > (le16_to_cpu(dev->descriptor.idProduct) > - == hfcsusb_idtab[i].idProduct)) { > + == hfcsusb_idtab[i].idProduct)) > vend_idx = i; > - continue; > - } > + There is no need to add a blank line here. julia > } > > printk(KERN_DEBUG > -- > 2.1.0 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/