Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755097AbbG1JVt (ORCPT ); Tue, 28 Jul 2015 05:21:49 -0400 Received: from mail-bn1bn0106.outbound.protection.outlook.com ([157.56.110.106]:51338 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750859AbbG1JVq convert rfc822-to-8bit (ORCPT ); Tue, 28 Jul 2015 05:21:46 -0400 X-Greylist: delayed 2015 seconds by postgrey-1.27 at vger.kernel.org; Tue, 28 Jul 2015 05:21:46 EDT From: Chen Bough To: Mark Rutland CC: "robh+dt@kernel.org" , Pawel Moll , "ijc+devicetree@hellion.org.uk" , "galak@codeaurora.org" , "shawnguo@kernel.org" , "kernel@pengutronix.de" , "linux@arm.linux.org.uk" , "dmitry.torokhov@gmail.com" , "hans.verkuil@cisco.com" , "hadess@hadess.net" , "mchehab@osg.samsung.com" , "mamlinav@gmail.com" , "arnd@arndb.de" , "jonathar@broadcom.com" , "hdegoede@redhat.com" , "christian.gmeiner@gmail.com" , "scott.liu@emc.com.tw" , "geert@linux-m68k.org" , "benjamin.tissoires@redhat.com" , "sebastien.szymanski@armadeus.com" , "sbranden@broadcom.com" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-input@vger.kernel.org" Subject: RE: [PATCH 2/5] Documentation: Detail permitted DT properties for the imx6ul_tsc Thread-Topic: [PATCH 2/5] Documentation: Detail permitted DT properties for the imx6ul_tsc Thread-Index: AQHQyF7AFhbC6VJYcEuR4+RgSwPqGZ3vLTqAgAFlLLA= Date: Tue, 28 Jul 2015 08:48:08 +0000 Message-ID: References: <1437996407-27266-1-git-send-email-haibo.chen@freescale.com> <1437996407-27266-3-git-send-email-haibo.chen@freescale.com> <20150727112547.GE9169@leverpostej> In-Reply-To: <20150727112547.GE9169@leverpostej> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: arm.com; dkim=none (message not signed) header.d=none; x-originating-ip: [199.59.226.141] x-microsoft-exchange-diagnostics: 1;BY1PR03MB1387;5:ZtYDSXS2uV6+ZvHQkqArVUoJEjovKLejbmEIe4U7mm+trgHMOu/jmmZ5dYhmZhAE+vbmXfLjZV8AjYk76cP8jDJyLcMo3mkYLylukgEk+zHYRaBhZ06UD3raXABIYTI1GDa6/v7BhmLM+6nRXMT+9g==;24:Pe0fLu+mQk2jUn/VzekO8l/zmJqnmmZP2PN/G4ZrgPGMZPeVI9sSP9Z+d3yhII40sEwMmn1FSPMoeYDgIh3/iz2hTf/EnysNtRAV41W3CNo=;20:IlOWLcSqY7iHJhA0+j31yol37a7CFwdYu1iTz91QoKNiXhQaIUT17Hx6CneldFWDKAgjj0QLKUcQhq86IxkI/w== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1387; by1pr03mb1387: X-MS-Exchange-Organization-RulesExecuted x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:BY1PR03MB1387;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1387; x-forefront-prvs: 06515DA04B x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(24454002)(377454003)(13464003)(77156002)(77096005)(86362001)(5003600100002)(33656002)(110136002)(40100003)(189998001)(5001960100002)(54356999)(76176999)(19580405001)(5002640100001)(50986999)(102836002)(66066001)(74316001)(19580395003)(2656002)(46102003)(87936001)(92566002)(106116001)(62966003)(2950100001)(2900100001)(76576001)(99286002)(7059030);DIR:OUT;SFP:1102;SCL:1;SRVR:BY1PR03MB1387;H:BY1PR03MB1388.namprd03.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jul 2015 08:48:08.2086 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1387 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2666 Lines: 79 Hi Mark, > -----Original Message----- > From: Mark Rutland [mailto:mark.rutland@arm.com] > Sent: Monday, July 27, 2015 7:26 PM > To: Chen Haibo-B51421 > Cc: robh+dt@kernel.org; Pawel Moll; ijc+devicetree@hellion.org.uk; > galak@codeaurora.org; shawnguo@kernel.org; kernel@pengutronix.de; > linux@arm.linux.org.uk; dmitry.torokhov@gmail.com; hans.verkuil@cisco.com; > hadess@hadess.net; mchehab@osg.samsung.com; mamlinav@gmail.com; > arnd@arndb.de; jonathar@broadcom.com; hdegoede@redhat.com; > christian.gmeiner@gmail.com; scott.liu@emc.com.tw; geert@linux-m68k.org; > benjamin.tissoires@redhat.com; sebastien.szymanski@armadeus.com; > sbranden@broadcom.com; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > input@vger.kernel.org > Subject: Re: [PATCH 2/5] Documentation: Detail permitted DT properties > for the imx6ul_tsc > > On Mon, Jul 27, 2015 at 12:26:44PM +0100, Haibo Chen wrote: > > Here we apply required documentation for the imx6ul touch screen > > controller driver which describe available properties and how to use > > them. > > > > Signed-off-by: Haibo Chen > > --- > > .../devicetree/bindings/input/touchscreen/imx6ul_tsc.txt | 14 > ++++++++++++++ > > 1 file changed, 14 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/input/touchscreen/imx6ul_tsc.txt > > > > diff --git > > a/Documentation/devicetree/bindings/input/touchscreen/imx6ul_tsc.txt > > b/Documentation/devicetree/bindings/input/touchscreen/imx6ul_tsc.txt > > new file mode 100644 > > index 0000000..e34d752 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/input/touchscreen/imx6ul_tsc.t > > +++ xt > > @@ -0,0 +1,14 @@ > > +* Freescale i.MX6UL Touch Controller > > + > > +Required properties: > > +- compatible: must be "fsl,imx6ul-tsc" > > + > > What about all the other properties in the example? [haibo] I will add other properties in the documentation. > > > +Example: > > + &tsc { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_tsc>; > > + status = "okay"; > > + xnur-gpio = <&gpio1 3 GPIO_ACTIVE_HIGH>; > > + measure_delay_time = <0xfff>; > > + pre_charge_time = <0xffff>; > > Thiose underscores should be dashes, and all the properties should be > documented. [haibo] I will change to "measure-delay-time" and "pre-charge-time" Thanks for your review! Haibo. > > Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/