From: Chen Bough <Haibo.Chen@freescale.com>
To: Shawn Guo <shawnguo@kernel.org>
CC: "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "pawel.moll@arm.com" <pawel.moll@arm.com>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>,
        "ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
        "galak@codeaurora.org" <galak@codeaurora.org>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
        "dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "sbranden@broadcom.com" <sbranden@broadcom.com>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "mchehab@osg.samsung.com" <mchehab@osg.samsung.com>,
        "christian.gmeiner@gmail.com" <christian.gmeiner@gmail.com>,
        "scott.liu@emc.com.tw" <scott.liu@emc.com.tw>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "hdegoede@redhat.com" <hdegoede@redhat.com>,
        "jonathar@broadcom.com" <jonathar@broadcom.com>,
        "benjamin.tissoires@redhat.com" <benjamin.tissoires@redhat.com>,
        "hans.verkuil@cisco.com" <hans.verkuil@cisco.com>,
        "hadess@hadess.net" <hadess@hadess.net>,
        "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
        "geert@linux-m68k.org" <geert@linux-m68k.org>,
        "sebastien.szymanski@armadeus.com" <sebastien.szymanski@armadeus.com>,
        "mamlinav@gmail.com" <mamlinav@gmail.com>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH 5/5] ARM: dts: imx6ul-14x14-evk.dts: add tsc support
Thread-Topic: [PATCH 5/5] ARM: dts: imx6ul-14x14-evk.dts: add tsc support
Thread-Index: AQHQyF7MlqKVmLIMY0SRn0lYnoeYcZ3vW/IAgAE3oFA=
Date: Tue, 28 Jul 2015 08:50:39 +0000
Message-ID: <BY1PR03MB1388B543998289A17C7B31A99A8D0@BY1PR03MB1388.namprd03.prod.outlook.com>
References: <1437996407-27266-1-git-send-email-haibo.chen@freescale.com>
 <1437996407-27266-6-git-send-email-haibo.chen@freescale.com>
 <20150727141259.GO12927@tiger>
In-Reply-To: <20150727141259.GO12927@tiger>
Accept-Language: zh-CN, en-US
Content-Language: en-US
by1pr03mb1387: X-MS-Exchange-Organization-RulesExecuted
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jul 2015 08:50:39.8213
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1387
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2773
Lines: 85


> -----Original Message-----
> From: Shawn Guo [mailto:shawnguo@kernel.org]
> Sent: Monday, July 27, 2015 10:13 PM
> To: Chen Haibo-B51421
> Cc: robh+dt@kernel.org; pawel.moll@arm.com; mark.rutland@arm.com;
> ijc+devicetree@hellion.org.uk; galak@codeaurora.org;
> kernel@pengutronix.de; linux@arm.linux.org.uk; dmitry.torokhov@gmail.com;
> devicetree@vger.kernel.org; sbranden@broadcom.com; arnd@arndb.de;
> mchehab@osg.samsung.com; christian.gmeiner@gmail.com;
> scott.liu@emc.com.tw; linux-kernel@vger.kernel.org; hdegoede@redhat.com;
> jonathar@broadcom.com; benjamin.tissoires@redhat.com;
> hans.verkuil@cisco.com; hadess@hadess.net; linux-input@vger.kernel.org;
> geert@linux-m68k.org; sebastien.szymanski@armadeus.com;
> mamlinav@gmail.com; linux-arm-kernel@lists.infradead.org
> Subject: Re: [PATCH 5/5] ARM: dts: imx6ul-14x14-evk.dts: add tsc support
> 
> On Mon, Jul 27, 2015 at 07:26:47PM +0800, Haibo Chen wrote:
> > Add touch screen surpport for i.MX6UL-EVK board.
> >
> > Signed-off-by: Haibo Chen <haibo.chen@freescale.com>
> > ---
> >  arch/arm/boot/dts/imx6ul-14x14-evk.dts | 18 ++++++++++++++++++
> >  1 file changed, 18 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx6ul-14x14-evk.dts
> b/arch/arm/boot/dts/imx6ul-14x14-evk.dts
> > index 61b41ee..323d32d 100644
> > --- a/arch/arm/boot/dts/imx6ul-14x14-evk.dts
> > +++ b/arch/arm/boot/dts/imx6ul-14x14-evk.dts
> > @@ -44,6 +44,15 @@
> >  	soc-supply = <&reg_soc>;
> >  };
> >
> > +&tsc {
> > +	pinctrl-names = "default";
> > +	pinctrl-0 = <&pinctrl_tsc>;
> > +	status = "okay";
> 
> We generally have "status" at the bottom of the property list.
> 
> Shawn
>
 
[haibo] Yes, it's my negligence, I will amend this.

> > +	xnur-gpio = <&gpio1 3 0>;
> > +	measure_delay_time = <0xffff>;
> > +	pre_charge_time = <0xfff>;
> > +};
> > +
> >  &uart1 {
> >  	pinctrl-names = "default";
> >  	pinctrl-0 = <&pinctrl_uart1>;
> > @@ -212,6 +221,15 @@
> >  		>;
> >  	};
> >
> > +	pinctrl_tsc: tscgrp {
> > +		fsl,pins = <
> > +			MX6UL_PAD_GPIO1_IO01__GPIO1_IO01		0xb0
> > +			MX6UL_PAD_GPIO1_IO02__GPIO1_IO02		0xb0
> > +			MX6UL_PAD_GPIO1_IO03__GPIO1_IO03		0xb0
> > +			MX6UL_PAD_GPIO1_IO04__GPIO1_IO04		0xb0
> > +		>;
> > +	};
> > +
> >  	pinctrl_uart1: uart1grp {
> >  		fsl,pins = <
> >  			MX6UL_PAD_UART1_TX_DATA__UART1_DCE_TX 0x1b0b1
> > --
> > 1.9.1
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/