Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755579AbbG1IwY (ORCPT ); Tue, 28 Jul 2015 04:52:24 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:34818 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752507AbbG1IwV (ORCPT ); Tue, 28 Jul 2015 04:52:21 -0400 Date: Tue, 28 Jul 2015 09:52:16 +0100 From: Lee Jones To: S Twiss Cc: DEVICETREE , Dmitry Torokhov , Ian Campbell , Kumar Gala , LINUXINPUT , LINUXKERNEL , Mark Rutland , Pawel Moll , RTCLINUX , Rob Herring , Samuel Ortiz , David Dajun Chen , Support Opensource Subject: Re: [PATCH V3 0/3] da9062: Add DA9062 OnKey support using the existing DA9063 OnKey driver Message-ID: <20150728085216.GP14943@x1> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3845 Lines: 86 > From: S Twiss Steve, Can you sort out your git configuration please. Your name should be represented in full. No abbreviations or synonyms please. I would expect to see: 'Steve Twiss ' The mailer is less important, but I suggest 'Steve Twiss' would be more professional than either 'S Twiss' or 'Opensource [Steve Twiss]'. I appreciate it might be company policy, but is there any chance of reversing that to read 'Steve Twiss [Opensource]' instead? > This patch set adds OnKey support for the Dialog DA9062 Power Management IC. > Changes are made to the existing DA9063 OnKey component so that functionality > in this device driver can be re-used to support the DA9062 OnKey. > > This following patch set re-uses the existing kernel OnKey driver for chips > whose OnKey blocks are functionally similar to the DA9063 OnKey. > > The main points for the MFD core and device tree changes are as follows. > > - Alteration of the DA9063 OnKey Kconfig needs to be updated to depend on > both MFD_DA9063 "or" MFD_DA9062. There is no explicit DA9062 OnKey Kconfig. > - The DA9062 MFD core should add a new OnKey resource as usual and an entry > in the mfd_cell to support a component name and of_compatible for > "da9062-onkey" and "dlg,da9062-onkey". > - The device tree binding support should include a compatible string for > "dlg,da9062-onkey" > > The main points for the OnKey changes are as follows: > > A generic structure is used (called da906x_chip_config) to hold all generic > registers and bitmasks for use with this type of OnKey component. > > Functions in the DA9063 OnKey will be refactored to use this compatibility > struct and all accesses to generic registers/masks will be made through > this table look-up instead of using defines from the register header files > directly > > Linkage between the DA9062 MFD and the DA9063 OnKey driver is created through > the use of an of_match_table entry in the platform_driver structure. > A re-work of da9063_onkey_probe() is necessary to use the of_match_node() and > dev_get_regmap() functions: this will provide initialisation of the generic > registers and masks and allow access to the regmap according to the correct > device tree specification. > > The addition of a of_device_id table for DA9063 and DA9062 default data > is created. > > In this patch set the following is provided: > - [PATCH V3 1/3]: MFD changes in DA9062 to support OnKey > - [PATCH V3 2/3]: Update existing DA9063 OnKey to add DA9062 support > - [PATCH V3 3/3]: Device tree bindings for DA9062 OnKey component > > This patch applies against linux-next and next-20150708 > > Thank you, > Steve Twiss, Dialog Semiconductor Ltd. > > S Twiss (3): > mfd: da9062: Support for the DA9063 OnKey in the DA9062 core > onkey: da9063: Add DA9062 OnKey capability to DA9063 OnKey driver > devicetree: da9062: Add device tree bindings for DA9062 OnKey > > .../devicetree/bindings/input/da9062-onkey.txt | 36 ++++++ > Documentation/devicetree/bindings/mfd/da9062.txt | 3 + > drivers/input/misc/Kconfig | 8 +- > drivers/input/misc/da9063_onkey.c | 129 +++++++++++++++++---- > drivers/mfd/da9062-core.c | 11 ++ > 5 files changed, 158 insertions(+), 29 deletions(-) > create mode 100644 Documentation/devicetree/bindings/input/da9062-onkey.txt > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/