Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932147AbbG1Jm0 (ORCPT ); Tue, 28 Jul 2015 05:42:26 -0400 Received: from down.free-electrons.com ([37.187.137.238]:52165 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755286AbbG1JmU (ORCPT ); Tue, 28 Jul 2015 05:42:20 -0400 Message-ID: <55B74E77.60904@free-electrons.com> Date: Tue, 28 Jul 2015 11:42:15 +0200 From: Gregory CLEMENT User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Sudeep Holla CC: Thomas Petazzoni , Lior Amsalem , Andrew Lunn , Jason Cooper , Tawfik Bayouk , Boris BREZILLON , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Nadav Haklai , Ezequiel Garcia , Maxime Ripard , "linux-arm-kernel@lists.infradead.org" , Sebastian Hesselbarth Subject: Re: [PATCH v2 3/4] ARM: mvebu: Allow using the GIC for wakeup in standby mode References: <1435684740-24912-1-git-send-email-gregory.clement@free-electrons.com> <1435684740-24912-4-git-send-email-gregory.clement@free-electrons.com> <20150701175436.7dff0754@free-electrons.com> <55B60FBE.7060606@arm.com> In-Reply-To: <55B60FBE.7060606@arm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1803 Lines: 61 Hi Sudeep, On 27/07/2015 13:02, Sudeep Holla wrote: > Hi Thomas/Gregory, > > On 01/07/15 16:54, Thomas Petazzoni wrote: >> Dear Gregory CLEMENT, >> >> On Tue, 30 Jun 2015 19:18:59 +0200, Gregory CLEMENT wrote: >> >>> static void __init mvebu_init_irq(void) >>> { >>> + if (of_machine_is_compatible("marvell,armada375") || >>> + of_machine_is_compatible("marvell,armada380") || >>> + of_machine_is_compatible("marvell,armada390")) >> >> What we really want to know is if we're using the GIC, so what about >> instead: >> >> np = of_find_compatible_node(NULL, NULL, "arm,cortex-a9-gic"); >> if (np) >> gic_set_irqchip_flags(IRQCHIP_SKIP_SET_WAKE | >> IRQCHIP_MASK_ON_SUSPEND); > > As I had mentioned before, this function was planned to be removed. tglx > has now pulled in the patch into tip/core[1]. If this patch is already > pulled in, it's better to revert so that it won't break the build in > linux-next. Since the flags are now moved to GIC driver, this patch is > no longer required. Sorry for the trouble. Your patch has been merged in th irq branch just a few day after I merged this one. But fortunately I can remove the commit from my branch without any trouble. It is done now. Thanks, Gregory > > Regards, > Sudeep > > [1] > https://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?h=irq/core&id=0d3f2c92e004c67404fabea19728c1962b777bd6 > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/