Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755563AbbG1Jwc (ORCPT ); Tue, 28 Jul 2015 05:52:32 -0400 Received: from rtits2.realtek.com ([60.250.210.242]:49509 "EHLO rtits2.realtek.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754834AbbG1Jwa (ORCPT ); Tue, 28 Jul 2015 05:52:30 -0400 Authenticated-By: X-SpamFilter-By: BOX Solutions SpamTrap 5.54 with qID t6S9qFXC021290, This message is accepted by code: ctloc85258 From: Hayes Wang To: Oliver Neukum CC: "netdev@vger.kernel.org" , nic_swsd , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" Subject: RE: [PATCH net 2/2] r8152: reset device when tx timeout Thread-Topic: [PATCH net 2/2] r8152: reset device when tx timeout Thread-Index: AQHQyQfsAkgiWm5QxkSJ+6atubJAl53wDnWAgACVJpA= Date: Tue, 28 Jul 2015 09:52:15 +0000 Message-ID: <0835B3720019904CB8F7AA43166CEEB2F3C3F1@RTITMBSV03.realtek.com.tw> References: <1394712342-15778-156-Taiwan-albertk@realtek.com> <1394712342-15778-158-Taiwan-albertk@realtek.com> <1438073799.11934.4.camel@suse.com> In-Reply-To: <1438073799.11934.4.camel@suse.com> Accept-Language: zh-TW, en-US Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.21.71.143] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t6S9qbNA015794 Content-Length: 722 Lines: 18 Oliver Neukum [mailto:oneukum@suse.com] > Sent: Tuesday, July 28, 2015 4:57 PM [...] > * usb_queue_reset_device - Reset a USB device from an atomic context > * @iface: USB interface belonging to the device to reset > * > * This function can be used to reset a USB device from an atomic > * context, where usb_reset_device() won't work (as it blocks). > > Please use it if you can. Your version for example is buggy. > It will oops if you unplug the device while a reset is scheduled. Thanks for your suggestion. I would replace it. Best Regards, Hayes ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?