Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933715AbbG1KSS (ORCPT ); Tue, 28 Jul 2015 06:18:18 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:36009 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755376AbbG1KSN (ORCPT ); Tue, 28 Jul 2015 06:18:13 -0400 Message-ID: <1438078689.20182.42.camel@edumazet-glaptop2.roam.corp.google.com> Subject: Re: [PATCH] Drivers: isdn: Drop unnecessary continue From: Eric Dumazet To: Shraddha Barke Cc: Karsten Keil , Julia Lawall , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 28 Jul 2015 12:18:09 +0200 In-Reply-To: <1438072868-5408-1-git-send-email-shraddha.6596@gmail.com> References: <1438072868-5408-1-git-send-email-shraddha.6596@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1334 Lines: 47 On Tue, 2015-07-28 at 14:11 +0530, Shraddha Barke wrote: > The semantic patch used to make this change is : > > @@ > @@ > for (...;...;...) { > ... > if (...) { > ... > - continue; > } > } > > Signed-off-by: Shraddha Barke > --- > drivers/isdn/hardware/mISDN/hfcsusb.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/isdn/hardware/mISDN/hfcsusb.c b/drivers/isdn/hardware/mISDN/hfcsusb.c > index 114f3bc..91beb83 100644 > --- a/drivers/isdn/hardware/mISDN/hfcsusb.c > +++ b/drivers/isdn/hardware/mISDN/hfcsusb.c > @@ -1921,10 +1921,9 @@ hfcsusb_probe(struct usb_interface *intf, const struct usb_device_id *id) > if ((le16_to_cpu(dev->descriptor.idVendor) > == hfcsusb_idtab[i].idVendor) && > (le16_to_cpu(dev->descriptor.idProduct) > - == hfcsusb_idtab[i].idProduct)) { > + == hfcsusb_idtab[i].idProduct)) > vend_idx = i; > - continue; > - } > + > } > > printk(KERN_DEBUG Well, it seems author intent was to use a break instead of a continue. Not a big deal... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/