Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933234AbbG1Kdw (ORCPT ); Tue, 28 Jul 2015 06:33:52 -0400 Received: from mail-lb0-f180.google.com ([209.85.217.180]:36328 "EHLO mail-lb0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932604AbbG1Kdu (ORCPT ); Tue, 28 Jul 2015 06:33:50 -0400 MIME-Version: 1.0 In-Reply-To: <20150728132113-mutt-send-email-mst@redhat.com> References: <1438076642-12080-1-git-send-email-graeme.gregory@linaro.org> <20150728130604-mutt-send-email-mst@redhat.com> <20150728132113-mutt-send-email-mst@redhat.com> Date: Tue, 28 Jul 2015 11:33:48 +0100 Message-ID: Subject: Re: [PATCH] virtio_mmio: add ACPI probing From: G Gregory To: "Michael S. Tsirkin" Cc: Peter Maydell , "virtualization@lists.linux-foundation.org" , lkml - Kernel Mailing List , Shannon Zhao , =?UTF-8?B?QWxleCBCZW5uw6ll?= Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2287 Lines: 62 On 28 July 2015 at 11:27, Michael S. Tsirkin wrote: > On Tue, Jul 28, 2015 at 11:12:33AM +0100, Peter Maydell wrote: >> On 28 July 2015 at 11:08, Michael S. Tsirkin wrote: >> > On Tue, Jul 28, 2015 at 10:44:02AM +0100, Graeme Gregory wrote: >> >> Added the match table and pointers for ACPI probing to the driver. >> >> >> >> This uses the same identifier for virt devices as being used for qemu >> >> ARM64 ACPI support. >> >> >> >> http://git.linaro.org/people/shannon.zhao/qemu.git/commit/d0bf1955a3ecbab4b51d46f8c5dda02b7e14a17e >> >> >> >> Signed-off-by: Graeme Gregory >> >> --- >> >> drivers/virtio/virtio_mmio.c | 10 ++++++++++ >> >> 1 file changed, 10 insertions(+) >> >> >> >> diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c >> >> index 10189b5..f499d9d 100644 >> >> --- a/drivers/virtio/virtio_mmio.c >> >> +++ b/drivers/virtio/virtio_mmio.c >> >> @@ -58,6 +58,7 @@ >> >> >> >> #define pr_fmt(fmt) "virtio-mmio: " fmt >> >> >> >> +#include >> >> #include >> >> #include >> >> #include >> >> @@ -732,12 +733,21 @@ static struct of_device_id virtio_mmio_match[] = { >> >> }; >> >> MODULE_DEVICE_TABLE(of, virtio_mmio_match); >> >> >> >> +#ifdef CONFIG_ACPI >> >> +static const struct acpi_device_id virtio_mmio_acpi_match[] = { >> >> + { "LNRO0005", }, >> >> + { } >> >> +}; >> > >> > Hmm - we have reserved QEMUXXXX in ASWG explicitly for this purpose. >> > >> > Pater - do you think it's a good idea to change this before QEMU 2.4 >> > is released? >> >> Shannon's call, I guess. I don't know enough about ACPI to say. >> I thought these ACPI IDs were already fixed because they were >> what the kernel was looking for... >> >> -- PMM > > Apparently not :) > We assigned LNRO in ASWG to avoid collisions with our prototypes/real platforms so it makes sense to me to switch to QEMUXXXX. I will submit a new patch if Shannon wants to switch to that form. Graeme -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/