Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932406AbbG1LLu (ORCPT ); Tue, 28 Jul 2015 07:11:50 -0400 Received: from mail-pd0-f181.google.com ([209.85.192.181]:36442 "EHLO mail-pd0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932094AbbG1LLs (ORCPT ); Tue, 28 Jul 2015 07:11:48 -0400 Date: Tue, 28 Jul 2015 16:41:38 +0530 From: Sudip Mukherjee To: Shraddha Barke Cc: Lidza Louina , devel@driverdev.osuosl.org, Greg Kroah-Hartman , driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org, Julia Lawall Subject: Re: [PATCH] Staging: dgnc: Merge lines and remove unused variable for immediate return Message-ID: <20150728111126.GA15027@sudip-pc> References: <1438005576-6463-1-git-send-email-shraddha.6596@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438005576-6463-1-git-send-email-shraddha.6596@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 647 Lines: 16 On Mon, Jul 27, 2015 at 07:29:36PM +0530, Shraddha Barke wrote: > This patch compresses two lines into a single line if immediate return > is found. Variable rc is dropped as it is no longer needed. > > - return rc; > + return wait_event_interruptible(un->un_flags_wait, ((un->un_flags & UN_EMPTY) == 0)); This is introducing new checkpatch warning about line more than 80 char. regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/