Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755036AbbG1MFD (ORCPT ); Tue, 28 Jul 2015 08:05:03 -0400 Received: from mail-ob0-f169.google.com ([209.85.214.169]:36806 "EHLO mail-ob0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752814AbbG1MFB (ORCPT ); Tue, 28 Jul 2015 08:05:01 -0400 MIME-Version: 1.0 In-Reply-To: <20150727032301.GA5637@vaishali-Ideapad-Z570> References: <20150727032301.GA5637@vaishali-Ideapad-Z570> Date: Tue, 28 Jul 2015 14:05:00 +0200 Message-ID: Subject: Re: [PATCH] soc: versatile: Use devm_kzalloc From: Linus Walleij To: Vaishali Thakkar Cc: Arnd Bergmann , Paul Gortmaker , Axel Lin , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1232 Lines: 32 On Mon, Jul 27, 2015 at 5:23 AM, Vaishali Thakkar wrote: > This patch introduces the use of devm_kzalloc and does away > with kfree in the probe function. > > Signed-off-by: Vaishali Thakkar Reviewed-by: Linus Walleij Please get this through ARM SoC or tell me if I should handle it. > Some comments on this patch and driver: > - Here, after this change there will be a kfree on the failure of > the regmap_read too. I am not sure if driver is currently missing > it or there is something else happening here. Also, I think there > should be soc_device_unregister under the regmap_read. Likely. There are sloppy errors everywhere. > - Moreover, get_maintainer.pl is not pointing me towards any particular > mailing list or maintainers. So, I am sending this patch to all > commiters as there are only three commits for this driver. This is my code, also my stupid bugs :/ Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/