Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752778AbbG1MsM (ORCPT ); Tue, 28 Jul 2015 08:48:12 -0400 Received: from mail-oi0-f50.google.com ([209.85.218.50]:36465 "EHLO mail-oi0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751945AbbG1MsK (ORCPT ); Tue, 28 Jul 2015 08:48:10 -0400 MIME-Version: 1.0 In-Reply-To: <1438069696-25303-1-git-send-email-ludovic.desroches@atmel.com> References: <20150715133048.GD14886@odux.rfo.atmel.com> <1438069696-25303-1-git-send-email-ludovic.desroches@atmel.com> Date: Tue, 28 Jul 2015 14:48:09 +0200 Message-ID: Subject: Re: [RESEND PATCH] pinctrl: at91: fix null pointer dereference From: Linus Walleij To: Ludovic Desroches Cc: "linux-gpio@vger.kernel.org" , Jean-Christophe PLAGNIOL-VILLARD , davidcdueck@googlemail.com, Alexandre Belloni , Nicolas Ferre , Boris Brezillon , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1409 Lines: 36 On Tue, Jul 28, 2015 at 9:48 AM, Ludovic Desroches wrote: > From: David Dueck > > Not all gpio banks are necessarily enabled, in the current code this can > lead to null pointer dereferences. > > [ 51.130000] Unable to handle kernel NULL pointer dereference at virtual address 00000058 (...) > > Signed-off-by: David Dueck > Acked-by: Ludovic Desroches > Acked-by: Alexandre Belloni > CC: Nicolas Ferre > CC: Boris Brezillon > CC: linux-arm-kernel@lists.infradead.org > CC: linux-kernel@vger.kernel.org > --- > > This patch fixes a oops in the kernel because of a NULL pointer in a table. > Having a NULL pointer in this table is the normal behavior if a PIO controller > is not enabled. So this fix is not a quick and dirty hack, it's usual to skip > an entry from a table if it is not filled. Fair enough, better too many checks than too few. Is this a regression to v4.2 that should go to stable or v4.3 material? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/