Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932691AbbG1Nzo (ORCPT ); Tue, 28 Jul 2015 09:55:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45760 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751878AbbG1NzQ (ORCPT ); Tue, 28 Jul 2015 09:55:16 -0400 Date: Tue, 28 Jul 2015 15:55:12 +0200 From: Jiri Olsa To: "Liang, Kan" Cc: "a.p.zijlstra@chello.nl" , "acme@kernel.org" , "luto@kernel.org" , "mingo@redhat.com" , "eranian@google.com" , "ak@linux.intel.com" , "mark.rutland@arm.com" , "Hunter, Adrian" , "jolsa@kernel.org" , "namhyung@kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH V2 4/6] perf,tools: save misc sample read value in struct perf_sample Message-ID: <20150728135512.GD28175@krava.brq.redhat.com> References: <1437745712-16649-1-git-send-email-kan.liang@intel.com> <1437745712-16649-5-git-send-email-kan.liang@intel.com> <20150726163153.GF24646@krava.brq.redhat.com> <37D7C6CF3E00A74B8858931C1DB2F077018CD12B@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <37D7C6CF3E00A74B8858931C1DB2F077018CD12B@SHSMSX103.ccr.corp.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1039 Lines: 32 On Mon, Jul 27, 2015 at 10:24:49PM +0000, Liang, Kan wrote: SNIP > > >freq_perf_data, > > > + sample- > > >read.group.values[nr].value); > > > > I think this should be in upper layer.. > > OK, I'll move it to deliver_sample_group. > > > why not do this also within > > iter_prepare_normal_entry as for the rest of the calculations I suggested > > in my other email > > Because we cannot get evlist in iter_add/prepare function. We cannot go > through all group members' value. > It's too complex (need to change many interfaces) to pass the evlist to > iter_add/prepare function hum, I remember Namhyung added iter->add_entry_cb, but seems it's called after the entry is added.. how about adding pre-addition callback? it can reach the report structure with perf_evlist jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/