Subject: Re: [PATCH 1/3] net: mdio-octeon: Modify driver to work on both
 ThunderX and Octeon
To: <mohun106@gmail.com>, <f.fainelli@gmail.com>, <netdev@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>
References: <1438049683-10630-1-git-send-email-mohun106@gmail.com>
 <1438049683-10630-2-git-send-email-mohun106@gmail.com>
CC: Radha Mohan Chintakuntla <rchintakuntla@cavium.com>,
        Sunil Goutham <sgoutham@cavium.com>,
        David Daney <david.daney@cavium.com>
From: David Daney <ddaney@caviumnetworks.com>
Message-ID: <55B78C9C.6080006@caviumnetworks.com>
Date: Tue, 28 Jul 2015 07:07:24 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: <1438049683-10630-2-git-send-email-mohun106@gmail.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
BY1PR0701MB1721: X-MS-Exchange-Organization-RulesExecuted
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2015 14:07:27.6953 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0701MB1721
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2286
Lines: 75

On 07/27/2015 07:14 PM, mohun106@gmail.com wrote:
> From: Radha Mohan Chintakuntla <rchintakuntla@cavium.com>
>
> This patch modifies the mdio-octeon driver to work on both ThunderX and
> Octeon SoCs from Cavium Inc.
>
> Signed-off-by: Sunil Goutham <sgoutham@cavium.com>
> Signed-off-by: Radha Mohan Chintakuntla <rchintakuntla@cavium.com>
> Signed-off-by: David Daney <david.daney@cavium.com>
> ---
>   drivers/net/phy/Kconfig       |    9 ++-
>   drivers/net/phy/mdio-octeon.c |  122 +++++++++++++++++++++++++++++++++++-----
>   2 files changed, 111 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
> index cf18940..0d6af19 100644
> --- a/drivers/net/phy/Kconfig
> +++ b/drivers/net/phy/Kconfig
> @@ -145,13 +145,14 @@ config MDIO_GPIO
>   	  will be called mdio-gpio.
>
>   config MDIO_OCTEON
> -	tristate "Support for MDIO buses on Octeon SOCs"
> -	depends on CAVIUM_OCTEON_SOC
> +	tristate "Support for MDIO buses on Octeon and ThunderX SOCs"
> +	depends on 64BIT
>   	default y

If it now depends only on 64BIT, we should probably remove the 
"default".  People building for x86 are not interested in this driver.


[...]
>
> +#ifdef __BIG_ENDIAN_BITFIELD
> +#define OCT_MDIO_BITFIELD_FIELD(field, more)	\
> +	field;					\
> +	more
> +
> +#else
> +#define OCT_MDIO_BITFIELD_FIELD(field, more)	\
> +	more					\
> +	field;
> +
> +#endif
> +
> +union cvmx_smix_clk {
> +	uint64_t u64;

Perhaps: s/uint64_t/u64/

There are several of these.


> +	struct cvmx_smix_clk_s {
> +	  OCT_MDIO_BITFIELD_FIELD(u64 reserved_25_63:39,
> +	  OCT_MDIO_BITFIELD_FIELD(u64 mode:1,
> +	  OCT_MDIO_BITFIELD_FIELD(u64 reserved_21_23:3,
> +	  OCT_MDIO_BITFIELD_FIELD(u64 sample_hi:5,
> +	  OCT_MDIO_BITFIELD_FIELD(u64 sample_mode:1,
> +	  OCT_MDIO_BITFIELD_FIELD(u64 reserved_14_14:1,
> +	  OCT_MDIO_BITFIELD_FIELD(u64 clk_idle:1,
> +	  OCT_MDIO_BITFIELD_FIELD(u64 preamble:1,
> +	  OCT_MDIO_BITFIELD_FIELD(u64 sample:4,
> +	  OCT_MDIO_BITFIELD_FIELD(u64 phase:8,
> +	  ;))))))))))
> +	} s;
> +};
> +
[...]
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/