Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753934AbbG1OTx (ORCPT ); Tue, 28 Jul 2015 10:19:53 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:34193 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751580AbbG1OTv (ORCPT ); Tue, 28 Jul 2015 10:19:51 -0400 Date: Tue, 28 Jul 2015 16:19:20 +0200 From: Peter Zijlstra To: Shuah Khan Cc: David Drysdale , linux-api@vger.kernel.org, Michael Kerrisk , Andrew Morton , Arnd Bergmann , Jonathan Corbet , Andrea Arcangeli , Thomas Gleixner , Eric B Munson , Ingo Molnar , "H. Peter Anvin" , Oleg Nesterov , Linus Torvalds , Greg Kroah-Hartman , Andy Lutomirski , Al Viro , Rusty Russell , Vivek Goyal , Alexei Starovoitov , David Herrmann , "Theodore Ts'o" , Kees Cook , Miklos Szeredi , Milosz Tanski , Fam Zheng , Josh Triplett , Mathieu Desnoyers , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC 0/1] Document how to add a new syscall Message-ID: <20150728141920.GC19282@twins.programming.kicks-ass.net> References: <1438083663-24814-1-git-send-email-drysdale@google.com> <55B78AB4.2010807@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55B78AB4.2010807@osg.samsung.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1376 Lines: 32 On Tue, Jul 28, 2015 at 07:59:16AM -0600, Shuah Khan wrote: > On 07/28/2015 05:41 AM, David Drysdale wrote: > > Given that I've gotten some of the details wrong in the past (and I've > > seen others do likewise), I thought it might be helpful to collate the > > best practices for adding a new system call to the kernel. > > > > Apologies for the wide circulation -- I've tried to include folk who've > > recently added or proposed a system call, as they're most likely to > > have opinions on: > > - whether this a useful addition to Documentation/ > > - whether the details of the advice are correct and complete. > > > > Shuah, is there anything more that should be added for the Testing > > section in particular? > > > > David, > > Looks good. You could add a one liner on in some cases, it might be > necessary to install headers before test compiles. Other than that, > the information looks good. For perf we still use the syscall() wrapper and we have hardcoded (fallback) syscall numbers in there in case they've not yet reached unistd.h. People update their kernels far more often than their userspace headers. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/