Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755610AbbG1OVF (ORCPT ); Tue, 28 Jul 2015 10:21:05 -0400 Received: from gloria.sntech.de ([95.129.55.99]:55209 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750844AbbG1OVE (ORCPT ); Tue, 28 Jul 2015 10:21:04 -0400 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Sjoerd Simons Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH 3/4] ARM: dts: rockchip: Add SPDIF transceiver for RK3188 Date: Tue, 28 Jul 2015 16:20:50 +0200 Message-ID: <3088613.6ISvoE3M9J@diego> User-Agent: KMail/4.14.1 (Linux/3.16.0-4-amd64; KDE/4.14.2; x86_64; ; ) In-Reply-To: <1438085011-16577-4-git-send-email-sjoerd.simons@collabora.co.uk> References: <1438085011-16577-1-git-send-email-sjoerd.simons@collabora.co.uk> <1438085011-16577-4-git-send-email-sjoerd.simons@collabora.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2290 Lines: 79 Hi, Am Dienstag, 28. Juli 2015, 14:03:30 schrieb Sjoerd Simons: > Add the SPDIF transceiver controller and pin for RK3188 > > Signed-off-by: Sjoerd Simons > --- > arch/arm/boot/dts/rk3188.dtsi | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/arch/arm/boot/dts/rk3188.dtsi b/arch/arm/boot/dts/rk3188.dtsi > index 0f23aed..43e9bdf 100644 > --- a/arch/arm/boot/dts/rk3188.dtsi > +++ b/arch/arm/boot/dts/rk3188.dtsi > @@ -121,6 +121,22 @@ > status = "disabled"; > }; > > + spdif: spdif@0x1011e000 { node names without 0x -> "spdif@1011e000" > + compatible = "rockchip,rk3188-spdif", "rockchip,rk3066-spdif"; > + reg = <0x1011e000 0x2000>; > + interrupts = ; > + #address-cells = <1>; > + #size-cells = <0>; > + pinctrl-names = "default"; > + pinctrl-0 = <&spdif_tx>; > + dmas = <&dmac1_s 8>; > + dma-names = "tx"; > + clock-names = "spdif_hclk", "spdif_clk"; > + clocks = <&cru HCLK_SPDIF>, <&cru SCLK_SPDIF>; > + status = "disabled"; > + #sound-dai-cells = <0>; if you're submitting a v2, could you try ordering stuff like this? + compatible = "rockchip,rk3188-spdif", "rockchip,rk3066-spdif"; + reg = <0x1011e000 0x2000>; + #address-cells = <1>; + #size-cells = <0>; + #sound-dai-cells = <0>; + clock-names = "spdif_hclk", "spdif_clk"; + clocks = <&cru HCLK_SPDIF>, <&cru SCLK_SPDIF>; + dmas = <&dmac1_s 8>; + dma-names = "tx"; + interrupts = ; + pinctrl-names = "default"; + pinctrl-0 = <&spdif_tx>; + status = "disabled"; The ordering I try to keep is "compatible", "reg", [everything else sorted alphabetically], "status" > + }; > + > cru: clock-controller@20000000 { > compatible = "rockchip,rk3188-cru"; > reg = <0x20000000 0x1000>; > @@ -462,6 +478,12 @@ > ; > }; > }; > + > + spdif { > + spdif_tx: spdif-tx { > + rockchip,pins = ; > + }; > + }; > }; > }; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/