From: Shenwei Wang <Shenwei.Wang@freescale.com>
To: Shawn Guo <shawnguo@kernel.org>
CC: "jason@lakedaemon.net" <jason@lakedaemon.net>,
        Huang Anson <Anson.Huang@freescale.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "shawn.guo@linaro.org" <shawn.guo@linaro.org>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH v6 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup
 sources
Thread-Topic: [PATCH v6 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup
 sources
Thread-Index: AQHQxKFBE7T9qugVyk2pPJOxP2xAkJ3vWnoAgAAFd/CAAAmzgIAAAPnwgACqK4CAAN0s0A==
Date: Tue, 28 Jul 2015 14:24:20 +0000
Message-ID: <CY1PR0301MB084367CD5008AA07C18AA9C0838D0@CY1PR0301MB0843.namprd03.prod.outlook.com>
References: <1437584859-64203-1-git-send-email-shenwei.wang@freescale.com>
 <1437584859-64203-2-git-send-email-shenwei.wang@freescale.com>
 <20150727134058.GL12927@tiger>
 <CY1PR0301MB084352861E63DA2DE286CC77838E0@CY1PR0301MB0843.namprd03.prod.outlook.com>
 <20150727143515.GQ12927@tiger>
 <CY1PR0301MB084351380311261C292872AB838E0@CY1PR0301MB0843.namprd03.prod.outlook.com>
 <20150728004746.GT12927@tiger>
In-Reply-To: <20150728004746.GT12927@tiger>
Accept-Language: zh-CN, en-US
Content-Language: en-US
blupr03mb1361: X-MS-Exchange-Organization-RulesExecuted
Content-Type: text/plain; charset="gb2312"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jul 2015 14:24:20.2647
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB1361
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t6SEOT8d018705
Content-Length: 1684
Lines: 53


> -----Original Message-----
> From: Shawn Guo [mailto:shawnguo@kernel.org]
> Sent: 2015??7??27?? 19:48
> To: Wang Shenwei-B38339
> Cc: jason@lakedaemon.net; Huang Yongcai-B20788;
> linux-kernel@vger.kernel.org; tglx@linutronix.de; shawn.guo@linaro.org;
> linux-arm-kernel@lists.infradead.org
> Subject: Re: [PATCH v6 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup
> sources
> 
> On Mon, Jul 27, 2015 at 02:50:15PM +0000, Shenwei Wang wrote:
> > The following structure is currently used in both drivers. The members
> > "gpc_base/ wakeup_sources/enabled_irqs" are now shared to PM driver.
> > And the macro IMR_NUM will be referred by both drivers too.
> >
> > struct imx_gpcv2_irq {
> > 	spinlock_t lock;
> > 	void __iomem *gpc_base;
> 
> So this is the virtual base used by both irqchip and pm driver, and the lock is for
> register access protection, right?  If so, we can define gpc as a syscon device,
> and access it from both drivers with regmap.

Regmap can be a solution too.

> > 	u32 wakeup_sources[IMR_NUM];
> 
> This should be an irqchip internal data and exported to external users like pm
> code with an interface like imx_gpcv2_get_wakeup_sources().

Okay.

> > 	u32 enabled_irqs[IMR_NUM];


> I do not see how this is used in pm driver.
> 
> > 	u32 cpu2wakeup;
> 
> The only use of this in pm driver is to unmask interrupt #32 during initialization.
> Why cannot it be done in irqchip driver initialization?

Right. This line should be moved to irqchip driver.

Thanks.
Shenwei 

> Shawn
> 
> > };
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?