Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755597AbbG1ObG (ORCPT ); Tue, 28 Jul 2015 10:31:06 -0400 Received: from mail.kernel.org ([198.145.29.136]:52206 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752296AbbG1ObE (ORCPT ); Tue, 28 Jul 2015 10:31:04 -0400 Date: Tue, 28 Jul 2015 22:30:45 +0800 From: Shawn Guo To: Shenwei Wang Cc: "jason@lakedaemon.net" , Huang Anson , "linux-kernel@vger.kernel.org" , "tglx@linutronix.de" , "shawn.guo@linaro.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v6 2/2] ARM: imx: Add suspend codes for imx7D Message-ID: <20150728143045.GG12927@tiger> References: <1437584859-64203-1-git-send-email-shenwei.wang@freescale.com> <1437584859-64203-3-git-send-email-shenwei.wang@freescale.com> <20150727132802.GK12927@tiger> <20150728010235.GU12927@tiger> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1767 Lines: 42 On Tue, Jul 28, 2015 at 02:16:20PM +0000, Shenwei Wang wrote: > > The files are named with "-imx7". It's a clear sign that the build of the files > > should be controlled by something like related to "imx7". > > Ideally, it should be CONFIG_SOC_IMX7. Since imx7d is the only supported imx7 > > soc and there is no CONFIG_SOC_IMX7 available so far, it falls on > > CONFIG_SOC_IMX7D. > > We can also interpret "-imx7" is the first SoC which has the GPCv2 block. In that case you should name the block gpc-imx7d rather than gpcv2 and symbol as GPC_IMX7D rather than IMX_GPCV2. > > > > > +extern struct imx_gpcv2_irq *gpcv2_irq_instance; > > > > > > > > Will this give a checkpatch warning? > > > > > > Yes. Any suggestion for that? Move it to a header file? > > > > Get rid of it. > > Then you may resolve the following compile error: You didn't get my point. Rather than defining it as a global variable, we should try to keep imx_gpcv2_irq as an internal data structure to irqchip driver, and use well-defined interface to access the data from pm driver when necessary. Shawn > > CC arch/arm/mach-imx/pm-imx7.o > arch/arm/mach-imx/pm-imx7.c: In function ‘imx_gpcv2_pm_init’: > arch/arm/mach-imx/pm-imx7.c:836:7: error: ‘gpcv2_irq_instance’ undeclared (first use in this function) > cd = gpcv2_irq_instance; > ^ > arch/arm/mach-imx/pm-imx7.c:836:7: note: each undeclared identifier is reported only once for each function it appears in > make[1]: *** [arch/arm/mach-imx/pm-imx7.o] Error 1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/