Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755736AbbG1OhN (ORCPT ); Tue, 28 Jul 2015 10:37:13 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:34892 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755445AbbG1OhK (ORCPT ); Tue, 28 Jul 2015 10:37:10 -0400 MIME-Version: 1.0 In-Reply-To: <201507281633.19407.marex@denx.de> References: <201507281633.19407.marex@denx.de> From: Michal Suchanek Date: Tue, 28 Jul 2015 16:36:29 +0200 Message-ID: Subject: Re: [PATCH 1/2] mtd: spi-nor: Add GD25LQ32C 1.8V SPI NOR flash ID To: Marek Vasut Cc: David Woodhouse , Brian Norris , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Huang Shijie , Ben Hutchings , =?UTF-8?B?QmVhbiBIdW8g6ZyN5paM5paMIChiZWFuaHVvKQ==?= , MTD Maling List , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1519 Lines: 39 On 28 July 2015 at 16:33, Marek Vasut wrote: > On Tuesday, July 28, 2015 at 11:07:57 AM, Michal Suchanek wrote: >> This 1.8V SPI NOR flash is found on ARM Chromebook XE303C and reads >> something like 25LQ32VIG in the middle. >> >> Signed-off-by: Michal Suchanek >> --- >> drivers/mtd/spi-nor/spi-nor.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c >> index d78831b..cba3bd0 100644 >> --- a/drivers/mtd/spi-nor/spi-nor.c >> +++ b/drivers/mtd/spi-nor/spi-nor.c >> @@ -559,6 +559,7 @@ static const struct spi_device_id spi_nor_ids[] = { >> >> /* GigaDevice */ >> { "gd25q32", INFO(0xc84016, 0, 64 * 1024, 64, SECT_4K) }, >> + { "gd25lq32c", INFO(0xc86016, 0, 64 * 1024, 64, SECT_4K) }, >> { "gd25q64", INFO(0xc84017, 0, 64 * 1024, 128, SECT_4K) }, >> { "gd25q128", INFO(0xc84018, 0, 64 * 1024, 256, SECT_4K) }, > > Don't we have DT bindings, so we can use jedec,spi-nor prop for all > new SPI NORs without growing this table ? When jedec,spi-nor compatible is used an attempt is made to identify the chip using this table. When the ID is not in the table (or is misread due to transfer error) spi-nor probe fails. Thanks Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/