Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932530AbbG1Oik (ORCPT ); Tue, 28 Jul 2015 10:38:40 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:37419 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932211AbbG1Oii (ORCPT ); Tue, 28 Jul 2015 10:38:38 -0400 X-Auth-Info: QZtHG4+730LKr6e5yhOEi90KIAYsUqp2d9oNlag8y1Y= From: Marek Vasut To: Michal Suchanek Subject: Re: [PATCH 1/2] mtd: spi-nor: Add GD25LQ32C 1.8V SPI NOR flash ID Date: Tue, 28 Jul 2015 16:38:35 +0200 User-Agent: KMail/1.13.7 (Linux/3.14-2-amd64; KDE/4.13.1; x86_64; ; ) Cc: David Woodhouse , Brian Norris , =?utf-8?q?Rafa=C5=82_Mi=C5=82ecki?= , Huang Shijie , Ben Hutchings , "Bean Huo =?utf-8?q?=E9=9C=8D=E6=96=8C=E6=96=8C?= (beanhuo)" , MTD Maling List , Linux Kernel Mailing List References: <201507281633.19407.marex@denx.de> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <201507281638.35845.marex@denx.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1750 Lines: 44 On Tuesday, July 28, 2015 at 04:36:29 PM, Michal Suchanek wrote: > On 28 July 2015 at 16:33, Marek Vasut wrote: > > On Tuesday, July 28, 2015 at 11:07:57 AM, Michal Suchanek wrote: > >> This 1.8V SPI NOR flash is found on ARM Chromebook XE303C and reads > >> something like 25LQ32VIG in the middle. > >> > >> Signed-off-by: Michal Suchanek > >> --- > >> > >> drivers/mtd/spi-nor/spi-nor.c | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/drivers/mtd/spi-nor/spi-nor.c > >> b/drivers/mtd/spi-nor/spi-nor.c index d78831b..cba3bd0 100644 > >> --- a/drivers/mtd/spi-nor/spi-nor.c > >> +++ b/drivers/mtd/spi-nor/spi-nor.c > >> @@ -559,6 +559,7 @@ static const struct spi_device_id spi_nor_ids[] = { > >> > >> /* GigaDevice */ > >> { "gd25q32", INFO(0xc84016, 0, 64 * 1024, 64, SECT_4K) }, > >> > >> + { "gd25lq32c", INFO(0xc86016, 0, 64 * 1024, 64, SECT_4K) }, > >> > >> { "gd25q64", INFO(0xc84017, 0, 64 * 1024, 128, SECT_4K) }, > >> { "gd25q128", INFO(0xc84018, 0, 64 * 1024, 256, SECT_4K) }, > > > > Don't we have DT bindings, so we can use jedec,spi-nor prop for all > > new SPI NORs without growing this table ? > > When jedec,spi-nor compatible is used an attempt is made to identify > the chip using this table. > > When the ID is not in the table (or is misread due to transfer error) > spi-nor probe fails. Dang, I was under the impression we want to avoid growing this table :( Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/