Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932407AbbG1OjK (ORCPT ); Tue, 28 Jul 2015 10:39:10 -0400 Received: from mail.kernel.org ([198.145.29.136]:53211 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752325AbbG1OjI (ORCPT ); Tue, 28 Jul 2015 10:39:08 -0400 Date: Tue, 28 Jul 2015 22:38:54 +0800 From: Shawn Guo To: Shenwei Wang Cc: "shawn.guo@linaro.org" , "tglx@linutronix.de" , "jason@lakedaemon.net" , Huang Anson , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v7 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup sources Message-ID: <20150728143854.GH12927@tiger> References: <1438025400-5919-1-git-send-email-shenwei.wang@freescale.com> <1438025400-5919-2-git-send-email-shenwei.wang@freescale.com> <20150728012452.GX12927@tiger> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1081 Lines: 30 On Tue, Jul 28, 2015 at 02:27:42PM +0000, Shenwei Wang wrote: > > > +static int gpcv2_wakeup_source_save(void) { > > > + struct imx_gpcv2_irq *cd; > > > > We generally name variables in an abbrev of the types to make them intuitive. I > > tried hard to map "cd" to "imx_gpcv2_irq" and failed. > > Can you help me on that? > > CD is the abbreviation of chip data which is a member of irq_data. You are defining a variable of type imx_gpcv2_irq, neither chip_data nor irq_data. > > > +void ca7_cpu_resume(void); > > > +void imx7_suspend(void __iomem *ocram_vbase); > > > > Why do these declarations need to be in this header? > > Just to resolve the compile errors. Wrong solution. They belong to some header in arch/arm/mach-imx not include/soc/imx, as there is no code outside arch/arm/mach-imx needs these declaration. Shawn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/