From: Shenwei Wang <Shenwei.Wang@freescale.com>
To: Shawn Guo <shawnguo@kernel.org>
CC: "shawn.guo@linaro.org" <shawn.guo@linaro.org>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "jason@lakedaemon.net" <jason@lakedaemon.net>,
        "Huang Anson" <Anson.Huang@freescale.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH v7 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup
 sources
Thread-Topic: [PATCH v7 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup
 sources
Thread-Index: AQHQyKLC5s2hbGQZ5kWxQLe9k167RZ3wFyEAgADZ4UCAAAP5AIAAAFKw
Date: Tue, 28 Jul 2015 14:46:35 +0000
Message-ID: <CY1PR0301MB084351EFDDA403AF522B3171838D0@CY1PR0301MB0843.namprd03.prod.outlook.com>
References: <1438025400-5919-1-git-send-email-shenwei.wang@freescale.com>
 <1438025400-5919-2-git-send-email-shenwei.wang@freescale.com>
 <20150728012452.GX12927@tiger>
 <CY1PR0301MB08438D52968A601F94DBB55C838D0@CY1PR0301MB0843.namprd03.prod.outlook.com>
 <20150728143854.GH12927@tiger>
In-Reply-To: <20150728143854.GH12927@tiger>
Accept-Language: zh-CN, en-US
Content-Language: en-US
by1pr03mb1372: X-MS-Exchange-Organization-RulesExecuted
Content-Type: text/plain; charset="gb2312"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jul 2015 14:46:35.7105
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1372
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t6SEkkbZ019026
Content-Length: 1702
Lines: 44

> -----Original Message-----
> From: Shawn Guo [mailto:shawnguo@kernel.org]
> Sent: 2015??7??28?? 9:39
> To: Wang Shenwei-B38339
> Cc: shawn.guo@linaro.org; tglx@linutronix.de; jason@lakedaemon.net; Huang
> Yongcai-B20788; linux-kernel@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org
> Subject: Re: [PATCH v7 1/2] irqchip: imx-gpcv2: IMX GPCv2 driver for wakeup
> sources
> 
> On Tue, Jul 28, 2015 at 02:27:42PM +0000, Shenwei Wang wrote:
> > > > +static int gpcv2_wakeup_source_save(void) {
> > > > +	struct imx_gpcv2_irq *cd;
> > >
> > > We generally name variables in an abbrev of the types to make them
> > > intuitive.  I tried hard to map "cd" to "imx_gpcv2_irq" and failed.
> > > Can you help me on that?
> >
> > CD is the abbreviation of chip data which is a member of irq_data.
> 
> You are defining a variable of type imx_gpcv2_irq, neither chip_data nor irq_data.

Imx_gpcv2_irq itself is the chip_data of irq_data.

> > > > +void ca7_cpu_resume(void);
> > > > +void imx7_suspend(void __iomem *ocram_vbase);
> > >
> > > Why do these declarations need to be in this header?
> >
> > Just to resolve the compile errors.
> 
> Wrong solution.  They belong to some header in arch/arm/mach-imx not
> include/soc/imx, as there is no code outside arch/arm/mach-imx needs these
> declaration.

It is a little ugly. I was thinking to have a gpcv2.h header file, so put them there. 
But as the header file is going to be removed, I am considering to move it to 
common.h. Although it seems not beautiful too.

Thanks,
Shenwei

> Shawn
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?