Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755547AbbG1O4f (ORCPT ); Tue, 28 Jul 2015 10:56:35 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:40620 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752190AbbG1O4d (ORCPT ); Tue, 28 Jul 2015 10:56:33 -0400 Date: Tue, 28 Jul 2015 07:56:32 -0700 From: Greg KH To: Bhaktipriya Shridhar Cc: lidza.louina@gmail.com, markh@compro.net, devel@driverdev.osuosl.org, driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: dgnc: dgnc_neo.c: Style and spelling fixes Message-ID: <20150728145632.GB19733@kroah.com> References: <20150728124805.GA6423@Karyakshetra> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150728124805.GA6423@Karyakshetra> User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1021 Lines: 27 On Tue, Jul 28, 2015 at 06:18:05PM +0530, Bhaktipriya Shridhar wrote: > This patch fixes: > 1.Fixes comments that are over 80-characters either by: > -breaking up comment lines, into multi-line comments (kernel style) or > -shortening comments (Done in 7 places): > - Changed "Why?Becuz" to "Since" (6 places) > - Removed the comment "Which I dont care about" (1 place) > 2.Fixes code lines that are over 80-characters by > -breaking up long math lines > -breaking up long function calls > 2.Spelling errors in comments. > -tho -> though > -baudrate -> baud rate When listing all of the different things your patch does, that should be a huge hint that it should be broken up into lots of different patches. Please do only one thing per patch. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/