Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753202AbbG1PTU (ORCPT ); Tue, 28 Jul 2015 11:19:20 -0400 Received: from mail-ig0-f177.google.com ([209.85.213.177]:33218 "EHLO mail-ig0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751979AbbG1PTT convert rfc822-to-8bit (ORCPT ); Tue, 28 Jul 2015 11:19:19 -0400 MIME-Version: 1.0 In-Reply-To: <201507281633.19407.marex@denx.de> References: <201507281633.19407.marex@denx.de> Date: Tue, 28 Jul 2015 17:19:18 +0200 Message-ID: Subject: Re: [PATCH 1/2] mtd: spi-nor: Add GD25LQ32C 1.8V SPI NOR flash ID From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= To: Marek Vasut Cc: Michal Suchanek , David Woodhouse , Brian Norris , Huang Shijie , Ben Hutchings , =?UTF-8?B?QmVhbiBIdW8g6ZyN5paM5paMIChiZWFuaHVvKQ==?= , "linux-mtd@lists.infradead.org" , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1377 Lines: 34 On 28 July 2015 at 16:33, Marek Vasut wrote: > On Tuesday, July 28, 2015 at 11:07:57 AM, Michal Suchanek wrote: >> This 1.8V SPI NOR flash is found on ARM Chromebook XE303C and reads >> something like 25LQ32VIG in the middle. >> >> Signed-off-by: Michal Suchanek >> --- >> drivers/mtd/spi-nor/spi-nor.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c >> index d78831b..cba3bd0 100644 >> --- a/drivers/mtd/spi-nor/spi-nor.c >> +++ b/drivers/mtd/spi-nor/spi-nor.c >> @@ -559,6 +559,7 @@ static const struct spi_device_id spi_nor_ids[] = { >> >> /* GigaDevice */ >> { "gd25q32", INFO(0xc84016, 0, 64 * 1024, 64, SECT_4K) }, >> + { "gd25lq32c", INFO(0xc86016, 0, 64 * 1024, 64, SECT_4K) }, >> { "gd25q64", INFO(0xc84017, 0, 64 * 1024, 128, SECT_4K) }, >> { "gd25q128", INFO(0xc84018, 0, 64 * 1024, 256, SECT_4K) }, > > Don't we have DT bindings, so we can use jedec,spi-nor prop for all > new SPI NORs without growing this table ? You confused this table with the one in m25p80.c. -- Rafał -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/