Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753111AbbG1RGp (ORCPT ); Tue, 28 Jul 2015 13:06:45 -0400 Received: from casper.infradead.org ([85.118.1.10]:45648 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752574AbbG1RGo (ORCPT ); Tue, 28 Jul 2015 13:06:44 -0400 Date: Tue, 28 Jul 2015 19:06:35 +0200 From: Peter Zijlstra To: Vikas Shivappa Cc: linux-kernel@vger.kernel.org, vikas.shivappa@intel.com, x86@kernel.org, hpa@zytor.com, tglx@linutronix.de, mingo@kernel.org, tj@kernel.org, matt.fleming@intel.com, will.auld@intel.com, glenn.p.williamson@intel.com, kanaka.d.juvva@intel.com Subject: Re: [PATCH 5/9] x86/intel_rdt: Add new cgroup and Class of service management Message-ID: <20150728170635.GU25159@twins.programming.kicks-ass.net> References: <1435789270-27010-1-git-send-email-vikas.shivappa@linux.intel.com> <1435789270-27010-6-git-send-email-vikas.shivappa@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1435789270-27010-6-git-send-email-vikas.shivappa@linux.intel.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 535 Lines: 13 On Wed, Jul 01, 2015 at 03:21:06PM -0700, Vikas Shivappa wrote: > +struct clos_cbm_map { > + unsigned long cache_mask; > + unsigned int clos_refcnt; > +}; This structure is not a map at all, its the map value. Furthermore, cache_mask seems a confusing name for the capacity bitmask (CBM). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/