Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753279AbbG1RI1 (ORCPT ); Tue, 28 Jul 2015 13:08:27 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:53919 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752096AbbG1RI0 (ORCPT ); Tue, 28 Jul 2015 13:08:26 -0400 Message-ID: <55B7B707.8060606@roeck-us.net> Date: Tue, 28 Jul 2015 10:08:23 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Lee Jones CC: Matt Fleming , Wim Van Sebroeck , linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, Mika Westerberg , Andy Shevchenko , Jean Delvare , Wolfram Sang , Matt Fleming , Peter Tyser , Samuel Ortiz , Aaron Sierra Subject: Re: [PATCH 1/5] iTCO_wdt: Expose watchdog properties using platform data References: <1438004292-16382-1-git-send-email-matt@codeblueprint.co.uk> <1438004292-16382-2-git-send-email-matt@codeblueprint.co.uk> <20150728094643.GT14943@x1> <20150728110717.GH2492@codeblueprint.co.uk> <20150728113721.GU14943@x1> <20150728124338.GA2773@codeblueprint.co.uk> <20150728150021.GX14943@x1> <55B79D60.4080807@roeck-us.net> <20150728152832.GY14943@x1> In-Reply-To: <20150728152832.GY14943@x1> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1487 Lines: 41 On 07/28/2015 08:28 AM, Lee Jones wrote: > On Tue, 28 Jul 2015, Guenter Roeck wrote: > >> On 07/28/2015 08:00 AM, Lee Jones wrote: >>> On Tue, 28 Jul 2015, Matt Fleming wrote: >>>> On Tue, 28 Jul, at 12:37:21PM, Lee Jones wrote: >>>>> >>>>> The driver shouldn't be called that either. >>>>> >>>>> You are the only one. What makes iTCO 'special'? >>>> >>>> I don't know, I didn't write it. It looks like Wim did ~9 years ago, so >>>> it must have made sense to him at the time. >>>> >> >> Coding style wasn't as strict then as it is today. iTCO has just been kept >> for historic reasons. > > For sure, I get that, but it doesn't mean we can't do-the-right-thing > (tm) now does it? > >> Sure, we could have changed it to lowercase, but so far no one bothered. >> Plus, of course, there is always the element that some maintainers hate >> that kind of cleanup, > > Really? Surely any kind of clean-up is good clean-up. Especially as > Greg KH et. al, have been doing public presentations telling everyone > that there is always kernel work for anyone who has the time; spelling > corrections and all. > Yes, really. Just try to submit cleanup patches to maintainers other than Greg and myself, and you'll see. It is a minefield. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/