Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752692AbbG1Rg7 (ORCPT ); Tue, 28 Jul 2015 13:36:59 -0400 Received: from mx2.suse.de ([195.135.220.15]:40470 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752596AbbG1Rg6 (ORCPT ); Tue, 28 Jul 2015 13:36:58 -0400 Subject: Re: [PATCH v1 3/7] ARM: dts: apq8064-ifc6410: add heart-beat led support. To: Srinivas Kandagatla , linux-arm-msm@vger.kernel.org References: <1438087956-17307-1-git-send-email-srinivas.kandagatla@linaro.org> <1438088040-17437-1-git-send-email-srinivas.kandagatla@linaro.org> Cc: agross@codeaurora.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Organization: SUSE Linux GmbH Message-ID: <55B7BDB8.7090103@suse.de> Date: Tue, 28 Jul 2015 19:36:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1438088040-17437-1-git-send-email-srinivas.kandagatla@linaro.org> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1616 Lines: 51 Am 28.07.2015 um 14:54 schrieb Srinivas Kandagatla: > This patch adds heart-beat led support on IFC6410. > > Signed-off-by: Srinivas Kandagatla > --- > arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts > index df560cf..1fc2ea5 100644 > --- a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts > +++ b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts > @@ -207,6 +207,19 @@ > status = "okay"; > }; > > + leds { > + compatible = "gpio-leds"; > + pinctrl-names = "default"; > + pinctrl-0 = <¬ify_led>; > + > + led@1 { > + label = "apq8064:green:user1"; > + gpios = <&pm8921_gpio 18 GPIO_ACTIVE_HIGH>; > + linux,default-trigger = "heartbeat"; Can we please drop the heartbeat default? While that's nice as proof of concept, it's annoying to deliver it that way in Linux distros. Users can enable that trigger with a simple boot script writing to /sys. Thanks, Andreas > + default-state = "on"; > + }; > + }; > + > qcom,ssbi@500000 { > pmicintc: pmic@0 { > pm8921_gpio: gpio@150 { [snip] -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany GF: Felix Imend?rffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N?rnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/