Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753510AbbG1SDE (ORCPT ); Tue, 28 Jul 2015 14:03:04 -0400 Received: from mail-yk0-f172.google.com ([209.85.160.172]:35825 "EHLO mail-yk0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752372AbbG1SDC (ORCPT ); Tue, 28 Jul 2015 14:03:02 -0400 Date: Tue, 28 Jul 2015 14:02:59 -0400 From: Tejun Heo To: Florian Fainelli Cc: Brian Norris , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, gregory.0xf0@gmail.com Subject: Re: [PATCH 4.2] ata: ahci_brcmstb: Fix warnings with CONFIG_PM_SLEEP=n Message-ID: <20150728180259.GK5322@mtj.duckdns.org> References: <1436904213-9205-1-git-send-email-f.fainelli@gmail.com> <20150714220629.GA21362@localhost> <55B68C5F.5050301@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55B68C5F.5050301@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1551 Lines: 40 On Mon, Jul 27, 2015 at 12:54:07PM -0700, Florian Fainelli wrote: > On 14/07/15 15:06, Brian Norris wrote: > > On Tue, Jul 14, 2015 at 01:03:33PM -0700, Florian Fainelli wrote: > >> When CONFIG_PM_SLEEP is disabled, brcm_ahci_{suspend,resume} are not > >> used, which causes such a build warning to occur: > >> > >> CC drivers/ata/ahci_brcmstb.o > >> drivers/ata/ahci_brcmstb.c:212:12: warning: 'brcm_ahci_suspend' defined > >> but not used [-Wunused-function] > >> static int brcm_ahci_suspend(struct device *dev) > >> ^ > >> drivers/ata/ahci_brcmstb.c:224:12: warning: 'brcm_ahci_resume' defined > >> but not used [-Wunused-function] > >> static int brcm_ahci_resume(struct device *dev) > >> ^ > >> LD drivers/ata/built-in.o > >> > >> Fixes: 766a2d979632 ("ata: add Broadcom AHCI SATA3 driver for STB chips") > >> Signed-off-by: Florian Fainelli > >> --- > >> Tejun, this is a new driver that got merged during 4.2, could you queue > >> this up for an upcoming 4.2-rcX pull request? > > > > Acked-by: Brian Norris > > > > Tejun, I am not seeing this change queued in your for-4.2-fixes branch > did you need me to do anything? Oops, I missed it, sorry. Applied to libata/for-4.2-fixes. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/