Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752994AbbG1TRl (ORCPT ); Tue, 28 Jul 2015 15:17:41 -0400 Received: from xes-mad.com ([216.165.139.218]:55899 "EHLO xes-mad.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752343AbbG1TRk (ORCPT ); Tue, 28 Jul 2015 15:17:40 -0400 X-Greylist: delayed 1694 seconds by postgrey-1.27 at vger.kernel.org; Tue, 28 Jul 2015 15:17:39 EDT Date: Tue, 28 Jul 2015 13:46:02 -0500 (CDT) From: Aaron Sierra To: Lee Jones Cc: Matt Fleming , Wim Van Sebroeck , linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, Mika Westerberg , Andy Shevchenko , Jean Delvare , Wolfram Sang , Matt Fleming , Peter Tyser , Samuel Ortiz Message-ID: <72454140.319490.1438109162683.JavaMail.zimbra@xes-inc.com> In-Reply-To: <20150728113721.GU14943@x1> References: <1438004292-16382-1-git-send-email-matt@codeblueprint.co.uk> <1438004292-16382-2-git-send-email-matt@codeblueprint.co.uk> <20150728094643.GT14943@x1> <20150728110717.GH2492@codeblueprint.co.uk> <20150728113721.GU14943@x1> Subject: Re: [PATCH 1/5] iTCO_wdt: Expose watchdog properties using platform data MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.52.16.65] X-Mailer: Zimbra 8.0.6_GA_5922 (ZimbraWebClient - FF39 (Linux)/8.0.6_GA_5922) Thread-Topic: iTCO_wdt: Expose watchdog properties using platform data Thread-Index: PIZESseeRLCvQzIyMnY0XYbBGZFjwQ== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1777 Lines: 44 > > > > @@ -933,7 +956,7 @@ gpe0_done: > > > > lpc_chipset_info[priv->chipset].use_gpio = ret; > > > > lpc_ich_enable_gpio_space(dev); > > > > > > > > - lpc_ich_finalize_cell(dev, &lpc_ich_cells[LPC_GPIO]); > > > > + lpc_ich_finalize_gpio_cell(dev); > > > > ret = mfd_add_devices(&dev->dev, PLATFORM_DEVID_AUTO, > > > > &lpc_ich_cells[LPC_GPIO], 1, NULL, 0, NULL); > > > > > > > > @@ -1007,7 +1030,10 @@ static int lpc_ich_init_wdt(struct pci_dev *dev) > > > > res->end = base_addr + ACPIBASE_PMC_END; > > > > } > > > > > > > > - lpc_ich_finalize_cell(dev, &lpc_ich_cells[LPC_WDT]); > > > > + ret = lpc_ich_finalize_wdt_cell(dev); > > > > + if (ret) > > > > + goto wdt_done; > > > > + > > > > ret = mfd_add_devices(&dev->dev, PLATFORM_DEVID_AUTO, > > > > &lpc_ich_cells[LPC_WDT], 1, NULL, 0, NULL); > > > > > > Why do you have an mfd_add_devices() call for each device? > > > > Good question. This call has been present since March 2012 when support > > was first added for iTCO_wdt in commit 887c8ec7219f ("watchdog: Convert > > iTCO_wdt driver to mfd model"). > > > > There's no good reason that I can see. Aaron? I chose to call mfd_add_devices() in each device init function because I thought it was the easiest way to avoid registering an incomplete/invalid MFD cell should an error occur during init. That way device registration wouldn't be an all-or-nothing affair. Doesn't mfd_add_devices() bail out after the first unsuccessful mfd to platform device translation? -Aaron S. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/