Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753277AbbG1TkJ (ORCPT ); Tue, 28 Jul 2015 15:40:09 -0400 Received: from mail-gw2-out.broadcom.com ([216.31.210.63]:49190 "EHLO mail-gw2-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753189AbbG1TkD (ORCPT ); Tue, 28 Jul 2015 15:40:03 -0400 X-IronPort-AV: E=Sophos;i="5.15,565,1432623600"; d="scan'208";a="70971526" From: "Chris (Christopher) Brand" To: Julien Grall , "xen-devel@lists.xenproject.org" CC: "linux-fbdev@vger.kernel.org" , "H. Peter Anvin" , Jiri Slaby , Thomas Gleixner , "stefano.stabellini@eu.citrix.com" , Russell King , "linux-scsi@vger.kernel.org" , "x86@kernel.org" , Tomi Valkeinen , "linux-input@vger.kernel.org" , Jean-Christophe Plagniol-Villard , "ian.campbell@citrix.com" , "James E.J. Bottomley" , Boris Ostrovsky , "Ingo Molnar" , "linux-arm-kernel@lists.infradead.org" , Juergen Gross , Wei Liu , Greg Kroah-Hartman , Dmitry Torokhov , "linux-kernel@vger.kernel.org" , David Vrabel , "netdev@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= Subject: RE: [Xen-devel] [PATCH 4/8] xen: Use the correctly the Xen memory terminologies Thread-Topic: [Xen-devel] [PATCH 4/8] xen: Use the correctly the Xen memory terminologies Thread-Index: AQHQyUb2RJXKc/r7dUuGRguphfmKpJ3xRn1w Date: Tue, 28 Jul 2015 19:39:57 +0000 Message-ID: <4EE5B48738DDED408878C97C8E050A8B1D7DDBB5@SJEXCHMB05.corp.ad.broadcom.com> References: <1438095769-2560-1-git-send-email-julien.grall@citrix.com> <1438095769-2560-5-git-send-email-julien.grall@citrix.com> In-Reply-To: <1438095769-2560-5-git-send-email-julien.grall@citrix.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.16.203.100] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t6SJeGh1020778 Content-Length: 762 Lines: 20 > Based on include/xen/mm.h [1], Linux is mistakenly using MFN when GFN is meant, > I suspect this is because the first support for Xen was for PV. This brough some Typo : "brought" Perhaps "resulted in" would be better ? > misimplementation of helpers on ARM and make the developper confused the expected behavior. Typo: "developer". I'd also suggest "...and confused developers about the...". [...] > For clarity and avoid new confusion, replace any reference of mfn into gnf in any helpers used by PV drivers. Typo : "gfn" I'd suggest "...replace any reference to mfn with gfn..." [...] Chris ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?