Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753117AbbG1U2t (ORCPT ); Tue, 28 Jul 2015 16:28:49 -0400 Received: from mail-la0-f50.google.com ([209.85.215.50]:35076 "EHLO mail-la0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752383AbbG1U2s (ORCPT ); Tue, 28 Jul 2015 16:28:48 -0400 MIME-Version: 1.0 In-Reply-To: References: <1438076642-12080-1-git-send-email-graeme.gregory@linaro.org> <20150728130604-mutt-send-email-mst@redhat.com> <20150728132113-mutt-send-email-mst@redhat.com> Date: Tue, 28 Jul 2015 21:28:46 +0100 Message-ID: Subject: Re: [PATCH] virtio_mmio: add ACPI probing From: G Gregory To: Peter Maydell Cc: "Michael S. Tsirkin" , "virtualization@lists.linux-foundation.org" , lkml - Kernel Mailing List , Shannon Zhao , =?UTF-8?B?QWxleCBCZW5uw6ll?= Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1914 Lines: 47 On 28 July 2015 at 21:12, Peter Maydell wrote: > On 28 July 2015 at 11:27, Michael S. Tsirkin wrote: >> On Tue, Jul 28, 2015 at 11:12:33AM +0100, Peter Maydell wrote: >>> On 28 July 2015 at 11:08, Michael S. Tsirkin wrote: >>> > On Tue, Jul 28, 2015 at 10:44:02AM +0100, Graeme Gregory wrote: >>> >> Added the match table and pointers for ACPI probing to the driver. >>> >> >>> >> This uses the same identifier for virt devices as being used for qemu >>> >> ARM64 ACPI support. >>> >> >>> >> http://git.linaro.org/people/shannon.zhao/qemu.git/commit/d0bf1955a3ecbab4b51d46f8c5dda02b7e14a17e >>> >> >>> >> Signed-off-by: Graeme Gregory > >>> >> +#ifdef CONFIG_ACPI >>> >> +static const struct acpi_device_id virtio_mmio_acpi_match[] = { >>> >> + { "LNRO0005", }, >>> >> + { } >>> >> +}; >>> > >>> > Hmm - we have reserved QEMUXXXX in ASWG explicitly for this purpose. >>> > >>> > Pater - do you think it's a good idea to change this before QEMU 2.4 >>> > is released? >>> >>> Shannon's call, I guess. I don't know enough about ACPI to say. >>> I thought these ACPI IDs were already fixed because they were >>> what the kernel was looking for... > >> Apparently not :) > > Mmm. I'm not terribly happy about stuff being in QEMU before the > ACPI spec for it has been finalised. We should not be picking > stuff randomly on the fly... > > If we want to fix the ACPI IDs QEMU is using for 2.4 then we > really need to do that now (ie within the next day or two). > It is upto the owner of the QEMU prefix to allocate numbers. This is not an issue for ACPI spec at all. Graeme -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/