Date: Tue, 28 Jul 2015 22:45:08 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>,
        Darren Hart <dvhart@infradead.org>,
        Torvald Riegel <triegel@redhat.com>,
        "Carlos O'Donell" <carlos@redhat.com>, Ingo Molnar <mingo@elte.hu>,
        Jakub Jelinek <jakub@redhat.com>,
        linux-man <linux-man@vger.kernel.org>,
        lkml <linux-kernel@vger.kernel.org>,
        Davidlohr Bueso <dave@stgolabs.net>, Arnd Bergmann <arnd@arndb.de>,
        Steven Rostedt <rostedt@goodmis.org>,
        Linux API <linux-api@vger.kernel.org>,
        Roland McGrath <roland@hack.frob.com>,
        Anton Blanchard <anton@samba.org>, Eric Dumazet <edumazet@google.com>,
        bill o gallmeister <bgallmeister@gmail.com>,
        Jan Kiszka <jan.kiszka@siemens.com>, Daniel Wagner <wagi@monom.org>,
        Rich Felker <dalias@libc.org>, Andy Lutomirski <luto@amacapital.net>,
        bert hubert <bert.hubert@netherlabs.nl>,
        Rusty Russell <rusty@rustcorp.com.au>,
        Heinrich Schuchardt <xypron.glpk@gmx.de>
Subject: Re: Next round: revised futex(2) man page for review
Message-ID: <20150728204508.GG19282@twins.programming.kicks-ass.net>
References: <55B61EF3.7080302@gmail.com>
 <alpine.DEB.2.11.1507282054370.3825@nanos>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <alpine.DEB.2.11.1507282054370.3825@nanos>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1371
Lines: 30

On Tue, Jul 28, 2015 at 10:23:51PM +0200, Thomas Gleixner wrote:

> >        FUTEX_WAKE (since Linux 2.6.0)
> >               This  operation  wakes at most val of the waiters that are
> >               waiting (e.g., inside FUTEX_WAIT) on the futex word at the
> >               address  uaddr.  Most commonly, val is specified as either
> >               1 (wake up a single waiter) or INT_MAX (wake up all  wait‐
> >               ers).   No  guarantee  is provided about which waiters are
> >               awoken (e.g., a waiter with a higher  scheduling  priority
> >               is  not  guaranteed to be awoken in preference to a waiter
> >               with a lower priority).
> 
> That's only correct up to Linux 2.6.21.
> 
> Since 2.6.22 we have a priority ordered wakeup. For SCHED_OTHER
> threads this takes the nice level into account. Threads with the same
> priority are woken in FIFO order.

Maybe don't mention the effects of SCHED_OTHER, order by nice value is
'wrong'.

Also, this code seems to use plist, which means it won't do the right
thing for SCHED_DEADLINE either.

Do we want to go fix that?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/