Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753469AbbG1VMh (ORCPT ); Tue, 28 Jul 2015 17:12:37 -0400 Received: from smtp.citrix.com ([66.165.176.89]:23022 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752774AbbG1VMf (ORCPT ); Tue, 28 Jul 2015 17:12:35 -0400 X-IronPort-AV: E=Sophos;i="5.15,566,1432598400"; d="scan'208";a="285379297" Message-ID: <55B7F035.6010201@citrix.com> Date: Tue, 28 Jul 2015 22:12:21 +0100 From: Andrew Cooper User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: "H. Peter Anvin" , Julien Grall , CC: , , , Jiri Slaby , Thomas Gleixner , "Russell King" , , Tomi Valkeinen , , Ingo Molnar , , "Jean-Christophe Plagniol-Villard" , , "James E.J. Bottomley" , Boris Ostrovsky , , "Juergen Gross" , Wei Liu , Greg Kroah-Hartman , Dmitry Torokhov , , David Vrabel , , , =?windows-1252?Q?Roger_Pau_Monn=E9?= Subject: Re: [Xen-devel] [PATCH 0/8] Use correctly the Xen memory terminologies in Linux References: <1438095769-2560-1-git-send-email-julien.grall@citrix.com> <55B7EECD.8050605@zytor.com> In-Reply-To: <55B7EECD.8050605@zytor.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1661 Lines: 39 On 28/07/15 22:06, H. Peter Anvin wrote: > On 07/28/2015 08:02 AM, Julien Grall wrote: >> Hi all, >> >> This patch series aims to use the memory terminologies described in >> include/linux/mm.h [1] for Linux xen code. >> >> Linux is using mistakenly MFN when GFN is meant, I suspect this is because the >> first support of Xen was for PV. This has brought some misimplementation >> of memory helpers on ARM and make the developper confused about the expected >> behavior. >> >> For instance, with pfn_to_mfn, we expect to get a MFN based on the name. >> Although, if we look at the implementation on x86, it's returning a GFN. >> Most of the callers are also using it this way. >> >> The first 2 patches of this series is ARM related in order to remove >> PV specific helpers which should not be used and fixing the implementation of >> pfn_to_mfn. >> >> The rest of the series is here rename most of the usage in the common code >> of MFN to GFN. I also took the opportunity to replace most of the call to >> pfn_to_gfn in the common code by page_to_gfn avoid construction such >> as pfn_to_gfn(page_to_pfn(...). >> >> Note the one xen-blkfront will be dropped by 64K series [2], I can include it >> if necessary. >> > Can we actually get some documentation for Xen before starting to change > names around? http://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=e758ed14f390342513405dd766e874934573e6cb ~Andrew -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/