Date: Tue, 28 Jul 2015 14:45:37 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Yury <yury.norov@gmail.com>
Cc: Cassidy Burden <cburden@codeaurora.org>, linux-arm-msm@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Alexey Klimov <klimov.linux@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Daniel Borkmann <dborkman@redhat.com>,
        Hannes Frederic Sowa <hannes@stressinduktion.org>,
        Lai Jiangshan <laijs@cn.fujitsu.com>, Mark Salter <msalter@redhat.com>,
        AKASHI Takahiro <takahiro.akashi@linaro.org>,
        Thomas Graf <tgraf@suug.ch>,
        Valentin Rothberg <valentinrothberg@gmail.com>,
        Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH] lib: Make _find_next_bit helper function inline
Message-Id: <20150728144537.67d46b5714c99d25f0bb33fb@linux-foundation.org>
In-Reply-To: <55B7F2C6.9010000@gmail.com>
References: <1438110564-19932-1-git-send-email-cburden@codeaurora.org>
	<55B7F2C6.9010000@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 787
Lines: 24

On Wed, 29 Jul 2015 00:23:18 +0300 Yury <yury.norov@gmail.com> wrote:

> But I think, before/after for x86 is needed as well.

That would be nice.

> And why don't you consider '__always_inline__'? Simple inline is only a 
> hint and
> guarantees nothing.

Yup.  My x86_64 compiler just ignores the "inline".  When I use
__always_inline, find_bit.o's text goes from 776 bytes to 863. 
Hopefully we get something in return for that bloat!


Also, if _find_next_bit() benefits from this then _find_next_bit_le()
will presumably also benefit.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/