Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751506AbbG1WIZ (ORCPT ); Tue, 28 Jul 2015 18:08:25 -0400 Received: from mga03.intel.com ([134.134.136.65]:17981 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751386AbbG1WIY (ORCPT ); Tue, 28 Jul 2015 18:08:24 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,566,1432623600"; d="scan'208";a="531916873" Date: Tue, 28 Jul 2015 15:08:19 -0700 (PDT) From: Vikas Shivappa X-X-Sender: vikas@vshiva-Udesk To: Peter Zijlstra cc: Vikas Shivappa , linux-kernel@vger.kernel.org, vikas.shivappa@intel.com, x86@kernel.org, hpa@zytor.com, tglx@linutronix.de, mingo@kernel.org, tj@kernel.org, matt.fleming@intel.com, will.auld@intel.com, glenn.p.williamson@intel.com, kanaka.d.juvva@intel.com Subject: Re: [PATCH 6/9] x86/intel_rdt: Add support for cache bit mask management In-Reply-To: <20150728163536.GS25159@twins.programming.kicks-ass.net> Message-ID: References: <1435789270-27010-1-git-send-email-vikas.shivappa@linux.intel.com> <1435789270-27010-7-git-send-email-vikas.shivappa@linux.intel.com> <20150728163536.GS25159@twins.programming.kicks-ass.net> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 843 Lines: 36 On Tue, 28 Jul 2015, Peter Zijlstra wrote: > On Wed, Jul 01, 2015 at 03:21:07PM -0700, Vikas Shivappa wrote: >> +static inline bool cbm_is_contiguous(unsigned long var) >> +{ >> + unsigned long maxcbm = MAX_CBM_LENGTH; >> + unsigned long first_bit, zero_bit; >> + >> + if (!var) >> + return false; >> + >> + first_bit = find_next_bit(&var, maxcbm, 0); > > We actually have: find_first_bit(). will fix Thanks, Vikas > >> + zero_bit = find_next_zero_bit(&var, maxcbm, first_bit); >> + >> + if (find_next_bit(&var, maxcbm, zero_bit) < maxcbm) >> + return false; >> + >> + return true; >> +} > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/