Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752127AbbG2Axi (ORCPT ); Tue, 28 Jul 2015 20:53:38 -0400 Received: from mail-pa0-f49.google.com ([209.85.220.49]:35817 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751246AbbG2Axh (ORCPT ); Tue, 28 Jul 2015 20:53:37 -0400 Date: Tue, 28 Jul 2015 17:53:32 -0700 From: =?iso-8859-1?Q?J=F6rn?= Engel To: David Rientjes Cc: Mike Kravetz , "linux-mm@kvack.org" , linux-kernel Subject: Re: hugetlb pages not accounted for in rss Message-ID: <20150729005332.GB17938@Sligo.logfs.org> References: <55B6BE37.3010804@oracle.com> <20150728183248.GB1406@Sligo.logfs.org> <55B7F0F8.8080909@oracle.com> <20150728222654.GA28456@Sligo.logfs.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1404 Lines: 33 On Tue, Jul 28, 2015 at 04:30:19PM -0700, David Rientjes wrote: > > It's not only the oom killer, I don't believe hugeltb pages are accounted > to the "rss" in memcg. They use the hugetlb_cgroup for that. Starting to > account for them in existing memcg deployments would cause them to hit > their memory limits much earlier. The "rss_huge" field in memcg only > represents transparent hugepages. > > I agree with your comment that having done this when hugetlbfs was > introduced would have been optimal. > > It's always difficult to add a new class of memory to an existing metric > ("new" here because it's currently unaccounted). > > If we can add yet another process metric to track hugetlbfs memory mapped, > then the test could be converted to use that. I'm not sure if the > jusitifcation would be strong enough, but you could try. Well, we definitely need something. Having a 100GB process show 3GB of rss is not very useful. How would we notice a memory leak if it only affects hugepages, for example? J?rn -- The object-oriented version of 'Spaghetti code' is, of course, 'Lasagna code'. (Too many layers). -- Roberto Waltman. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/