Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751775AbbG2BGn (ORCPT ); Tue, 28 Jul 2015 21:06:43 -0400 Received: from seldrel01.sonyericsson.com ([37.139.156.2]:8572 "EHLO seldrel01.sonyericsson.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750932AbbG2BGm (ORCPT ); Tue, 28 Jul 2015 21:06:42 -0400 Message-ID: <55B82716.1060008@sonymobile.com> Date: Tue, 28 Jul 2015 18:06:30 -0700 From: Tim Bird User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Rob Herring , CC: "linux-arm-msm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , , , Greg Kroah-Hartman , Bjorn Andersson Subject: Bug: shared usb dt document is incorrect Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1305 Lines: 35 Antoine and Rob, I was just doing some testing with USB on a Qualcomm SoC. I followed the instructions in the binding document: Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt which has a compatible for "qcom,ci-hdrc", and is, in general, for chipidea-based USB controllers. It says in the document that the property usb-phy is deprecated, and to use phys and phy-names instead. However, the Qualcomm driver for this still uses usb-phy. That driver is in: drivers/usb/chipidea/ci_hdrc_msm.c I'm guessing I should update the Qualcomm driver to use phys and phy-names, but wanted to check with you-all to verify that this is the preferred method of getting phys by phandle now. It's either change the driver or make an exception in the binding document, I believe. I presume I should be changing devm_usb_get_phy_by_phandle() to of_phy_get(), but let me know if there's more to it than that. In case I change the driver, do I then update the binding doc to remove the information about the deprecated property, or not? Please advise. -- Tim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/