Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753372AbbG2HKj (ORCPT ); Wed, 29 Jul 2015 03:10:39 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:56710 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752560AbbG2HKh (ORCPT ); Wed, 29 Jul 2015 03:10:37 -0400 Date: Wed, 29 Jul 2015 00:10:36 -0700 (PDT) Message-Id: <20150729.001036.271920963041164246.davem@davemloft.net> To: al.drozdov@gmail.com Cc: dborkman@redhat.com, edumazet@google.com, willemb@google.com, viro@zeniv.linux.org.uk, eyal.birger@gmail.com, mst@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] packet: tpacket_snd(): fix signed/unsigned comparison From: David Miller In-Reply-To: <1438081021-1321-1-git-send-email-al.drozdov@gmail.com> References: <1438081021-1321-1-git-send-email-al.drozdov@gmail.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 29 Jul 2015 00:10:37 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 765 Lines: 22 From: Alexander Drozdov Date: Tue, 28 Jul 2015 13:57:01 +0300 > tpacket_fill_skb() can return a negative value (-errno) which > is stored in tp_len variable. In that case the following > condition will be (but shouldn't be) true: > > tp_len > dev->mtu + dev->hard_header_len > > as dev->mtu and dev->hard_header_len are both unsigned. > > That may lead to just returning an incorrect EMSGSIZE errno > to the user. > > Signed-off-by: Alexander Drozdov Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/